RTCCertificate serialization.

webrtc/base/fakesslidentity.h

Index: webrtc/base/fakesslidentity.h
diff --git a/webrtc/base/fakesslidentity.h b/webrtc/base/fakesslidentity.h
index 47ff86d03a827ebdf3a9a72f0bb6bf65ae278609..1960efbd664530e7277977097e68ee444a1ba95f 100644
--- a/webrtc/base/fakesslidentity.h
+++ b/webrtc/base/fakesslidentity.h
@@ -98,6 +98,11 @@ class FakeSSLIdentity : public rtc::SSLIdentity {
     return new FakeSSLIdentity(*this);
   }
   virtual const FakeSSLCertificate& certificate() const { return cert_; }
+  virtual std::string PrivateKeyToPemString() const {

[torbjorng (webrtc), 2016/04/21 15:16:00]

Please use "override".

[hbos, 2016/04/22 13:19:29]

This is a file where virtual is used everywhere. It makes sense to use override
for new functions, but I think that will break chromium fyi bots where some
compilation option says not to mix virtual and override in the same .cc,
something the webrtc bots don't check for. I've had to revert or do follow up
CLs before because of this.

I think virtual->override replacements should be done in a separate CL. I could
do that if you want.

[nisse-webrtc, 2016/04/22 13:44:06]

I think the inconsistent-override warning applies per class, not per file (but
I'm not 100% sure). I agree updating old code can be done in a separate cl.

[hbos, 2016/04/25 14:23:23]

Acknowledged.

+    // Not implemented.
+    RTC_NOTREACHED();
+    return "";
+  }
  private:
   FakeSSLCertificate cert_;
 };