RTCCertificate serialization.

webrtc/base/fakesslidentity.h

 /*
  *  Copyright 2012 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 80 matching lines @@
 };
 
 class FakeSSLIdentity : public rtc::SSLIdentity {
  public:
   explicit FakeSSLIdentity(const std::string& data) : cert_(data) {}
   explicit FakeSSLIdentity(const FakeSSLCertificate& cert) : cert_(cert) {}
   virtual FakeSSLIdentity* GetReference() const {
     return new FakeSSLIdentity(*this);
   }
   virtual const FakeSSLCertificate& certificate() const { return cert_; }
+  virtual std::string PrivateKeyToPemString() const {

[torbjorng (webrtc), 2016/04/21 15:16:00]

Please use "override".

[hbos, 2016/04/22 13:19:29]

This is a file where virtual is used everywhere. It makes sense to use override
for new functions, but I think that will break chromium fyi bots where some
compilation option says not to mix virtual and override in the same .cc,
something the webrtc bots don't check for. I've had to revert or do follow up
CLs before because of this.

I think virtual->override replacements should be done in a separate CL. I could
do that if you want.

[nisse-webrtc, 2016/04/22 13:44:06]

I think the inconsistent-override warning applies per class, not per file (but
I'm not 100% sure). I agree updating old code can be done in a separate cl.

[hbos, 2016/04/25 14:23:23]

Acknowledged.

+    // Not implemented.
+    RTC_NOTREACHED();
+    return "";
+  }
  private:
   FakeSSLCertificate cert_;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_FAKESSLIDENTITY_H_