FMTP parameters for the H.264 codec (merged)

FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793
Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971
Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)

R=tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/9b89249e81ab81830d780c9926dfd8242afa66ed

[hta-webrtc, 2016-04-19 06:36:02]

Description was changed from

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793
NOTRY=True

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)
==========

to

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793
NOTRY=True

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)
==========

[hta-webrtc, 2016-04-19 06:36:03]

hta@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hta-webrtc, 2016-04-19 06:36:20]

The CQ bit was checked by hta@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 06:36:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898063002/1

[commit-bot: I haz the power, 2016-04-19 06:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 06:36:28]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[tommi, 2016-04-19 08:51:58]

https://codereview.webrtc.org/1898063002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/1898063002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:1599: if (name.compare(kFmtpParams[i]) == 0) {
did we end up deciding on using compare() after all?  I thought Justin pointed
to a different document where it looked like we should be using _stricmp()?

[tommi, 2016-04-19 08:56:00]

lgtm

[hta-webrtc, 2016-04-19 08:56:48]

Description was changed from

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793
NOTRY=True

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)
==========

to

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)

TBR=
==========

[hta-webrtc, 2016-04-19 08:57:18]

Description was changed from

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)

TBR=
==========

to

==========
FMTP parameters for the H.264 codec (merged)

CL 2:
Don't write spaces after semicolons in FMTP lines.

Reference: RFC 6184 section 8.2.1 and examples.

BUG=webrtc:5793

Review URL: https://codereview.webrtc.org/1888373002

Cr-Commit-Position: refs/heads/master@{#12383}
(cherry picked from commit 62a216ee1e7359882b1b7d084a6897746ad0dd20)

CL 1:
Generate FMTP parameters for the H.264 codec.

This CL generates FMTP parameters that allow H.264 interoperation
with Firefox for the default codec list.

BUG=chromium:591971

Review URL: https://codereview.webrtc.org/1880963002

Cr-Commit-Position: refs/heads/master@{#12333}
(cherry picked from commit a6b99448eec51527eca0bc59f6da71061d02e807)

R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9b89249e81ab81830d780c992...
==========

[hta-webrtc, 2016-04-19 08:57:19]

Committed patchset #1 (id:1) manually as
9b89249e81ab81830d780c9926dfd8242afa66ed (presubmit successful).

[tommi, 2016-04-19 08:57:48]

On 2016/04/19 08:56:00, tommi-webrtc wrote:
> lgtm

for future drive-by's: We discussed the compare() vs _stricmp thing offline. 
It's ok as is in this cl because it's comparing constants to other constants
(maybe it should just be pointer comparisons?).  A followup cl will be made.