Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by hta-webrtc Modified:
4 years, 8 months ago Reviewers:
tommi, kjellander_webrtc, juberti2 CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti1, pthatcher1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDon't write spaces after semicolons in FMTP lines.
Reference: RFC 6184 section 8.2.1 and examples.
BUG=webrtc:5793
NOTRY=True
Committed: https://crrev.com/62a216ee1e7359882b1b7d084a6897746ad0dd20
Cr-Commit-Position: refs/heads/master@{#12383}
Patch Set 1 #Patch Set 2 : Removed a space in an objc test expectation #
Created: 4 years, 8 months ago
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888373002/1
Description was changed from ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=5793 ========== to ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=5793 ==========
hta@webrtc.org changed reviewers: + tommi@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/6684)
lgtm
The CQ bit was checked by hta@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org Link to the patchset: https://codereview.webrtc.org/1888373002/#ps20001 (title: "Removed a space in an objc test expectation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888373002/20001
Description was changed from ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=5793 ========== to ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hta@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888373002/20001
juberti@chromium.org changed reviewers: + juberti@chromium.org
lgtm ugly, but I agree with your interpretation
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 ========== to ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 NOTRY=True ==========
On 2016/04/15 17:22:04, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) > win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) Adding NOTRY=True to land via CQ. I'm confident the tryjobs that ran are enough. I'll try to scramble resources to improve our overloaded CQ since it's really hurting productivity lately.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888373002/20001
Message was sent while issue was closed.
Description was changed from ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 NOTRY=True ========== to ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 NOTRY=True ========== to ========== Don't write spaces after semicolons in FMTP lines. Reference: RFC 6184 section 8.2.1 and examples. BUG=webrtc:5793 NOTRY=True Committed: https://crrev.com/62a216ee1e7359882b1b7d084a6897746ad0dd20 Cr-Commit-Position: refs/heads/master@{#12383} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/62a216ee1e7359882b1b7d084a6897746ad0dd20 Cr-Commit-Position: refs/heads/master@{#12383} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
