Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.

Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.
EncodedImageCallback is used by all encoder implementations and seems to be what we should try to use in the transport.
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the PayLoadRouter.

BUG=webrtc:5687
Committed: https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb
Cr-Commit-Position: refs/heads/master@{#12436}

[perkj_webrtc, 2016-04-19 12:06:30]

Description was changed from

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.

BUG=
==========

to

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport. 
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687
==========

[perkj_webrtc, 2016-04-19 12:06:30]

perkj@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[perkj_webrtc, 2016-04-19 12:07:20]

Stefan - can you take a first look? 

pbos- please also help out.

[stefan-webrtc, 2016-04-19 13:43:13]

lgtm

I'd have preferred to clean up EncodedImageCallback a bit, for instance by using
bool return values (or void) for the Encoded method. I can see how that is non
trivial though...

https://codereview.webrtc.org/1897233002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_sender_unittest.cc (right):

https://codereview.webrtc.org/1897233002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_sender_unittest.cc:89: class
EncodedFrameCallback : public EncodedImageCallback {
EncodedFrameCallback inheriting from EncodedImageCallback? What :)

I'd prefer EncodedImageCallbackImpl if it's simply an implementation.

[perkj_webrtc, 2016-04-19 14:30:05]

Thanks- I found my bug in PayLoadRouter. 

pbos- please?

https://codereview.webrtc.org/1897233002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_sender_unittest.cc (right):

https://codereview.webrtc.org/1897233002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_sender_unittest.cc:89: class
EncodedFrameCallback : public EncodedImageCallback {
On 2016/04/19 13:43:12, stefan-webrtc (holmer) wrote:
> EncodedFrameCallback inheriting from EncodedImageCallback? What :)
> 
> I'd prefer EncodedImageCallbackImpl if it's simply an implementation.

Done.

[pbos-webrtc, 2016-04-19 14:59:24]

lgtm

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/include/video_codec_interface.h (right):

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/include/video_codec_interface.h:93:
CodecSpecificInfo() { memset(this, 0, sizeof(CodecSpecificInfo)); }
Remove for now and do separately per our discussion

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_coding_impl.cc (left):

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_coding_impl.cc:57: // TODO(andresp): Change to
void as return value is ignored.
TODO to change to bool, I dunno?

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream_tests.cc (left):

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/video/video_send_s...
webrtc/video/video_send_stream_tests.cc:1811: specifics.codecType =
kVideoCodecGeneric;
Maybe just set the specifics.codecSpecific.generic.simulcast_idx = 0 part?

[perkj_webrtc, 2016-04-20 07:12:13]

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_coding_impl.cc (left):

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_coding_impl.cc:57: // TODO(andresp): Change to
void as return value is ignored.
On 2016/04/19 14:59:24, pbos-webrtc wrote:
> TODO to change to bool, I dunno?

void make sence in the end. I will add a todo where its defined.

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream_tests.cc (left):

https://codereview.webrtc.org/1897233002/diff/60001/webrtc/video/video_send_s...
webrtc/video/video_send_stream_tests.cc:1811: specifics.codecType =
kVideoCodecGeneric;
On 2016/04/19 14:59:24, pbos-webrtc wrote:
> Maybe just set the specifics.codecSpecific.generic.simulcast_idx = 0 part?

Acknowledged.

[perkj_webrtc, 2016-04-20 07:12:18]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-04-20 07:12:18]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1897233002/#ps80001 (title:
"Addressed pbos nits.")

[commit-bot: I haz the power, 2016-04-20 07:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897233002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897233002/80001

[commit-bot: I haz the power, 2016-04-20 08:17:06]

Description was changed from

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport. 
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687
==========

to

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport. 
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687
==========

[commit-bot: I haz the power, 2016-04-20 08:17:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-20 08:17:19]

Description was changed from

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport. 
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687
==========

to

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport.
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687

Committed: https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb
Cr-Commit-Position: refs/heads/master@{#12436}
==========

[commit-bot: I haz the power, 2016-04-20 08:17:20]

Patchset 5 (id:??) landed as
https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb
Cr-Commit-Position: refs/heads/master@{#12436}

[kjellander_webrtc, 2016-04-20 11:13:08]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/1903193002/ by kjellander@webrtc.org.

The reason for reverting is: API changes broke downstream..

[perkj_webrtc, 2016-04-20 11:37:38]

Description was changed from

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport.
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc::5687

Committed: https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb
Cr-Commit-Position: refs/heads/master@{#12436}
==========

to

==========
Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback
instead.
EncodedImageCallback is used by all encoder implementations and seems to be what
we should try to use in the transport.
EncodedImageCallback can of course be cleaned up in the future.

This moves creation of RTPVideoHeader from the GenericEncoder to the
PayLoadRouter.

BUG=webrtc:5687

Committed: https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb
Cr-Commit-Position: refs/heads/master@{#12436}
==========