Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding_defines.h

Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed pbos nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 enum VCMTemporalDecimation { 50 enum VCMTemporalDecimation {
51 kBitrateOverUseDecimation, 51 kBitrateOverUseDecimation,
52 }; 52 };
53 53
54 struct VCMFrameCount { 54 struct VCMFrameCount {
55 uint32_t numKeyFrames; 55 uint32_t numKeyFrames;
56 uint32_t numDeltaFrames; 56 uint32_t numDeltaFrames;
57 }; 57 };
58 58
59 // Callback class used for sending data ready to be packetized 59 // Callback class used for sending data ready to be packetized
60 // Deprecated.
61 // TODO(perkj): Remove once OnEncoderImplementationName is not used.
60 class VCMPacketizationCallback { 62 class VCMPacketizationCallback {
61 public: 63 public:
62 virtual int32_t SendData(uint8_t payloadType, 64 // TODO(perkj): Refactor this. It does not belong in VCMPacketizationCallback.
63 const EncodedImage& encoded_image,
64 const RTPFragmentationHeader* fragmentationHeader,
65 const RTPVideoHeader* rtpVideoHdr) = 0;
66
67 virtual void OnEncoderImplementationName(const char* implementation_name) {} 65 virtual void OnEncoderImplementationName(const char* implementation_name) {}
68 66
69 protected: 67 protected:
70 virtual ~VCMPacketizationCallback() {} 68 virtual ~VCMPacketizationCallback() {}
71 }; 69 };
72 70
73 // Callback class used for passing decoded frames which are ready to be 71 // Callback class used for passing decoded frames which are ready to be
74 // rendered. 72 // rendered.
75 class VCMReceiveCallback { 73 class VCMReceiveCallback {
76 public: 74 public:
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 public: 207 public:
210 virtual void RenderBufferSizeMs(int buffer_size_ms) = 0; 208 virtual void RenderBufferSizeMs(int buffer_size_ms) = 0;
211 209
212 protected: 210 protected:
213 virtual ~VCMRenderBufferSizeCallback() {} 211 virtual ~VCMRenderBufferSizeCallback() {}
214 }; 212 };
215 213
216 } // namespace webrtc 214 } // namespace webrtc
217 215
218 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_ 216 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/generic_encoder.cc ('k') | webrtc/modules/video_coding/utility/ivf_file_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698