Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log: https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff: https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True

Committed: https://crrev.com/470dd37b41fd108b31f63841d308a58f5e2d5afd
Cr-Commit-Position: refs/heads/master@{#12422}

[kjellander_webrtc, 2016-04-19 02:01:00]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-19 02:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896953004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896953004/1

[commit-bot: I haz the power, 2016-04-19 02:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 02:06:14]

Try jobs failed on following builders:
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8651)

[kjellander_webrtc, 2016-04-19 09:10:13]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org, kwiberg@webrtc.org

[kjellander_webrtc, 2016-04-19 09:10:13]

kwiberg: review code changes
henrika: root rubberstamp.

[henrika_webrtc, 2016-04-19 09:11:13]

LGTM

[kwiberg-webrtc, 2016-04-19 09:21:02]

lgtm, but please consider providing move constructors in addition to copy
constructors for all three classes.

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.cc
File webrtc/base/pathutils.cc (right):

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.cc#...
webrtc/base/pathutils.cc:16: #endif  // WEBRTC_WIN
Your editor seems to be auto-cleaning trailing whitespace in the entire file.
With a CL much larger than this one, that might have been distracting.

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.h
File webrtc/base/pathutils.h (right):

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.h#n...
webrtc/base/pathutils.h:47: Pathname(const Pathname&);
It's more efficient to move than to copy std::string (which is the type of two
of Pathname's member variables), so please provide a move constructor too
(otherwise the compiler will copy even when it could have moved). It's exactly
like the copy constructor, but with argument Pathname&& instead of const
Pathname&.

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/audio_encoder.h (right):

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/audio_encoder.h:48: EncodedInfo(const
EncodedInfo&);
This class has a std::vector member variable, so please provide a move
constructor too.

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/desktop_region.h (right):

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/desktop_region.h:50: Row(const Row&);
This class has a std::vector member variable, so please provide a move
constructor too.

[kjellander_webrtc, 2016-04-19 09:31:09]

Description was changed from

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
==========

to

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which was fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
==========

[kjellander_webrtc, 2016-04-19 09:53:53]

I tried with the move constructors but then I get errors like this:
../../webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc:221:16:
error: object of type 'webrtc::AudioEncoder::EncodedInfo' cannot be assigned
because its copy assignment operator is implicitly deleted
 encoded_info = encoder_stack_->Encode(
              ^
../../webrtc/modules/audio_coding/codecs/audio_encoder.h:49:5: note: copy
assignment operator is implicitly deleted because 'EncodedInfo' has a
user-declared move constructor
   EncodedInfo(EncodedInfo&&);
   ^

So I'm sticking with the current version.

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.cc
File webrtc/base/pathutils.cc (right):

https://codereview.webrtc.org/1896953004/diff/20001/webrtc/base/pathutils.cc#...
webrtc/base/pathutils.cc:16: #endif  // WEBRTC_WIN
On 2016/04/19 09:21:01, kwiberg-webrtc wrote:
> Your editor seems to be auto-cleaning trailing whitespace in the entire file.
> With a CL much larger than this one, that might have been distracting.

Well, it's just this file so I'm gonna let them be fixed.

[kjellander_webrtc, 2016-04-19 09:57:59]

Description was changed from

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which was fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
==========

to

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
==========

[kjellander_webrtc, 2016-04-19 09:58:13]

Description was changed from

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
==========

to

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True
==========

[kjellander_webrtc, 2016-04-19 09:58:17]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-19 09:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896953004/20001

[commit-bot: I haz the power, 2016-04-19 10:03:28]

Description was changed from

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True
==========

to

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-19 10:03:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-19 10:03:39]

Description was changed from

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True
==========

to

==========
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.

Change log:
https://chromium.googlesource.com/chromium/src/+log/212f976fef..61ed337cfe
Full diff:
https://chromium.googlesource.com/chromium/src/+/212f976fef..61ed337cfe

No dependencies changed.
No update to Clang.

TBR=
NOTRY=True

Committed: https://crrev.com/470dd37b41fd108b31f63841d308a58f5e2d5afd
Cr-Commit-Position: refs/heads/master@{#12422}
==========

[commit-bot: I haz the power, 2016-04-19 10:03:40]

Patchset 2 (id:??) landed as
https://crrev.com/470dd37b41fd108b31f63841d308a58f5e2d5afd
Cr-Commit-Position: refs/heads/master@{#12422}

[kwiberg-webrtc, 2016-04-19 11:21:42]

On 2016/04/19 09:53:53, kjellander (webrtc) wrote:
> I tried with the move constructors but then I get errors like this:
> ../../webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc:221:16:
> error: object of type 'webrtc::AudioEncoder::EncodedInfo' cannot be assigned
> because its copy assignment operator is implicitly deleted
>  encoded_info = encoder_stack_->Encode(
>               ^
> ../../webrtc/modules/audio_coding/codecs/audio_encoder.h:49:5: note: copy
> assignment operator is implicitly deleted because 'EncodedInfo' has a
> user-declared move constructor
>    EncodedInfo(EncodedInfo&&);
>    ^
> 
> So I'm sticking with the current version.

I found the problem: the error message says we need to manually define a copy
*assignment operator*, but we had constructors on our minds and didn't read it
carefully enough.

I've made a follow-up CL that adds move constructors and copy+move assignment
operators: https://codereview.webrtc.org/1899173002/