Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)

webrtc/base/pathutils.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 26 matching lines @@
 // non-period/non-delimiter characters, and basename is non-empty.
 ///////////////////////////////////////////////////////////////////////////////
 
 class Pathname {
 public:
   // Folder delimiters are slash and backslash
   static bool IsFolderDelimiter(char ch);
   static char DefaultFolderDelimiter();
 
   Pathname();
+  Pathname(const Pathname&);

[kwiberg-webrtc, 2016/04/19 09:21:02]

It's more efficient to move than to copy std::string (which is the type of two
of Pathname's member variables), so please provide a move constructor too
(otherwise the compiler will copy even when it could have moved). It's exactly
like the copy constructor, but with argument Pathname&& instead of const
Pathname&.

   Pathname(const std::string& pathname);
   Pathname(const std::string& folder, const std::string& filename);
 
   // Set's the default folder delimiter for this Pathname
   char folder_delimiter() const { return folder_delimiter_; }
   void SetFolderDelimiter(char delimiter);
 
   // Normalize changes all folder delimiters to folder_delimiter()
   void Normalize();
 
@@ skipping 99 matching lines @@
     return false;
   }
   return Filesystem::DeleteFolderContents(path);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 }  // namespace rtc
 
 #endif // WEBRTC_BASE_PATHUTILS_H__