Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1891163002: Fix bug causing audio to stop being sent when AudioSendStreams are recreated. (Closed)

Created:
4 years, 8 months ago by The Sun (google.com)
Modified:
4 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tnakamura-webrtc, tlegrand-webrtc, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@51
Target Ref:
refs/pending/branch-heads/51
Project:
webrtc
Visibility:
Public.

Description

Fix bug causing audio to stop being sent when AudioSendStreams are recreated. BUG=chromium:602989, webrtc:5772 Review URL: https://codereview.webrtc.org/1881793006 Cr-Commit-Position: refs/heads/master@{#12347} (cherry picked from commit 6d6e7c5e1ac4b033e919cf562cc34ccc3b37f201) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
The Sun (google.com)
On 2016/04/15 08:49:43, the sun wrote: > mailto:solenberg@webrtc.org changed reviewers: > + mailto:tommi@webrtc.org Ping tommi@ ...
4 years, 8 months ago (2016-04-18 08:04:30 UTC) #3
The Sun (google.com)
On 2016/04/18 08:04:30, solenberg wrote: > On 2016/04/15 08:49:43, the sun wrote: > > mailto:solenberg@webrtc.org ...
4 years, 8 months ago (2016-04-18 18:56:54 UTC) #4
tommi
lgtm
4 years, 8 months ago (2016-04-18 19:06:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891163002/1
4 years, 8 months ago (2016-04-18 19:06:56 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 19:07:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698