Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1881793006: Fix bug causing audio to stop being sent when AudioSendStreams are recreated. (Closed)

Created:
4 years, 8 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix bug causing audio to stop being sent when AudioSendStreams are recreated. BUG=webrtc:5772 Committed: https://crrev.com/6d6e7c5e1ac4b033e919cf562cc34ccc3b37f201 Cr-Commit-Position: refs/heads/master@{#12347}

Patch Set 1 #

Patch Set 2 : unrelated change #

Patch Set 3 : Added regression test #

Patch Set 4 : Better test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
tommi
lgtm! verified that the issue is fixed.
4 years, 8 months ago (2016-04-13 14:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881793006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881793006/60001
4 years, 8 months ago (2016-04-13 15:00:50 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-13 16:07:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 16:07:43 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6d6e7c5e1ac4b033e919cf562cc34ccc3b37f201
Cr-Commit-Position: refs/heads/master@{#12347}

Powered by Google App Engine
This is Rietveld 408576698