Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1888593004: Delete all use of tick_util.h. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete all use of tick_util.h. Depends on Chrome cl https://codereview.chromium.org/1888003002/, which was landed some time ago. BUG=webrtc:5740 R=stefan@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/d28db7fd652bc1eb2cf7c10c948fb06cd9536398 Cr-Commit-Position: refs/heads/master@{#12674}

Patch Set 1 #

Total comments: 38

Patch Set 2 : Address Stefan's comments. #

Total comments: 2

Patch Set 3 : Rebase. #

Patch Set 4 : Update Mac FullScreenChromeWindowDetector. #

Total comments: 1

Patch Set 5 : Rebase, after TimeMillis renaming. #

Patch Set 6 : Update android jni files. Delete tick_utils.cc and .h. #

Patch Set 7 : Rebased. #

Patch Set 8 : Rebase. #

Patch Set 9 : Break overlong lines. #

Patch Set 10 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -518 lines) Patch
M webrtc/api/java/jni/androidmediacodeccommon.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 1 2 3 4 5 6 7 7 chunks +5 lines, -8 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 2 3 4 5 6 7 7 chunks +7 lines, -6 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/libyuv/scaler_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_video/video_render_frames.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/APITest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/Channel.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/test/iSACTest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/time_scheduler.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/time_scheduler.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_wave_win.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_file_processor.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 2 11 chunks +41 lines, -37 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc View 1 2 3 5 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 4 5 6 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/ssrc_database.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/utility/source/file_player_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.h View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 2 3 4 7 chunks +14 lines, -15 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 2 3 4 5 6 7 8 13 chunks +29 lines, -23 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/content_analysis.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/video_decimator.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/tick_util.h View 1 2 3 4 5 1 chunk +0 lines, -190 lines 0 comments Download
M webrtc/system_wrappers/source/clock.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/source/tick_util.cc View 1 2 3 4 5 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/test/TestSort/TestSort.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/call_stats.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/call_stats_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_remb.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_remb_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_sync_module.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/vie_sync_module.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/voice_engine/monitor_module.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 68 (28 generated)
nisse-webrtc
4 years, 8 months ago (2016-04-14 15:09:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/1
4 years, 8 months ago (2016-04-14 15:09:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/13832) mac_gn_dbg on ...
4 years, 8 months ago (2016-04-14 15:13:03 UTC) #6
stefan-webrtc
Thanks for taking the time to clean this up. Question for both you and tommi: ...
4 years, 8 months ago (2016-04-19 09:19:13 UTC) #7
tommi
On 2016/04/19 09:19:13, stefan-webrtc (holmer) wrote: > Thanks for taking the time to clean this ...
4 years, 8 months ago (2016-04-19 09:24:07 UTC) #8
nisse-webrtc
On 2016/04/19 09:24:07, tommi-webrtc wrote: > On 2016/04/19 09:19:13, stefan-webrtc (holmer) wrote: > > Thanks ...
4 years, 8 months ago (2016-04-19 12:18:52 UTC) #9
nisse-webrtc
https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc File webrtc/audio/audio_receive_stream.cc (right): https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc#newcode173 webrtc/audio/audio_receive_stream.cc:173: int64_t arrival_time_ms = rtc::Time64(); On 2016/04/19 09:19:12, stefan-webrtc (holmer) ...
4 years, 8 months ago (2016-04-19 12:19:25 UTC) #10
tommi
On 2016/04/19 12:18:52, nisse-webrtc wrote: > On 2016/04/19 09:24:07, tommi-webrtc wrote: > > On 2016/04/19 ...
4 years, 8 months ago (2016-04-19 12:28:16 UTC) #11
stefan-webrtc
https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc File webrtc/audio/audio_receive_stream.cc (right): https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc#newcode173 webrtc/audio/audio_receive_stream.cc:173: int64_t arrival_time_ms = rtc::Time64(); On 2016/04/19 12:19:25, nisse-webrtc wrote: ...
4 years, 8 months ago (2016-04-19 12:40:47 UTC) #12
nisse-webrtc
https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc File webrtc/audio/audio_receive_stream.cc (right): https://codereview.webrtc.org/1888593004/diff/1/webrtc/audio/audio_receive_stream.cc#newcode173 webrtc/audio/audio_receive_stream.cc:173: int64_t arrival_time_ms = rtc::Time64(); On 2016/04/19 12:40:47, stefan-webrtc (holmer) ...
4 years, 8 months ago (2016-04-19 13:48:51 UTC) #13
The Sun (google.com)
https://codereview.webrtc.org/1888593004/diff/60001/webrtc/system_wrappers/source/clock.cc File webrtc/system_wrappers/source/clock.cc (right): https://codereview.webrtc.org/1888593004/diff/60001/webrtc/system_wrappers/source/clock.cc#newcode40 webrtc/system_wrappers/source/clock.cc:40: return rtc::Time64(); drive-by: Is the plan to change Time64()/Time32() ...
4 years, 8 months ago (2016-04-19 17:46:41 UTC) #15
nisse-webrtc
On 2016/04/19 17:46:41, The Sun (google.com) wrote: > https://codereview.webrtc.org/1888593004/diff/60001/webrtc/system_wrappers/source/clock.cc > File webrtc/system_wrappers/source/clock.cc (right): > > ...
4 years, 8 months ago (2016-04-22 12:07:18 UTC) #16
stefan-webrtc
On 2016/04/22 12:07:18, nisse-webrtc wrote: > On 2016/04/19 17:46:41, The Sun (http://google.com) wrote: > > ...
4 years, 8 months ago (2016-04-26 08:20:50 UTC) #17
nisse-webrtc
> In that case I prefer landing the rename first, and then moving everything to ...
4 years, 7 months ago (2016-04-27 07:20:03 UTC) #18
stefan-webrtc
On 2016/04/27 07:20:03, nisse-webrtc wrote: > > In that case I prefer landing the rename ...
4 years, 7 months ago (2016-04-27 07:27:56 UTC) #19
pbos-webrtc
On 2016/04/27 07:27:56, stefan-webrtc (holmer) wrote: > On 2016/04/27 07:20:03, nisse-webrtc wrote: > > > ...
4 years, 7 months ago (2016-04-27 09:26:08 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/80001
4 years, 7 months ago (2016-05-02 15:40:18 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/12704)
4 years, 7 months ago (2016-05-02 15:46:50 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/120001
4 years, 7 months ago (2016-05-04 10:52:18 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5292)
4 years, 7 months ago (2016-05-04 11:09:44 UTC) #29
stefan-webrtc
lgtm
4 years, 7 months ago (2016-05-06 11:29:38 UTC) #30
nisse-webrtc
Tommi, Solenberg, do you have any additional comments?
4 years, 7 months ago (2016-05-09 07:09:50 UTC) #31
tommi
lgtm
4 years, 7 months ago (2016-05-09 07:48:39 UTC) #32
the sun
On 2016/05/09 07:09:50, nisse-webrtc wrote: > Tommi, Solenberg, do you have any additional comments? Yes, ...
4 years, 7 months ago (2016-05-09 08:01:32 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/120001
4 years, 7 months ago (2016-05-09 12:43:06 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/3805) android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 12:44:38 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/140001
4 years, 7 months ago (2016-05-10 06:36:17 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/14950)
4 years, 7 months ago (2016-05-10 06:47:07 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/140001
4 years, 7 months ago (2016-05-10 08:39:50 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5401)
4 years, 7 months ago (2016-05-10 08:50:41 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/160001
4 years, 7 months ago (2016-05-10 13:12:01 UTC) #50
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3856)
4 years, 7 months ago (2016-05-10 13:19:59 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/160001
4 years, 7 months ago (2016-05-10 13:27:15 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3858)
4 years, 7 months ago (2016-05-10 13:34:02 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/160001
4 years, 7 months ago (2016-05-10 13:49:42 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3862)
4 years, 7 months ago (2016-05-10 13:55:33 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888593004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888593004/160001
4 years, 7 months ago (2016-05-10 14:11:54 UTC) #62
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3865)
4 years, 7 months ago (2016-05-10 14:20:26 UTC) #64
nisse-webrtc
Committed patchset #10 (id:180001) manually as d28db7fd652bc1eb2cf7c10c948fb06cd9536398 (presubmit successful).
4 years, 7 months ago (2016-05-10 14:32:08 UTC) #67
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 14:32:09 UTC) #68
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/d28db7fd652bc1eb2cf7c10c948fb06cd9536398
Cr-Commit-Position: refs/heads/master@{#12674}

Powered by Google App Engine
This is Rietveld 408576698