Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h

Issue 1888593004: Delete all use of tick_util.h. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_ 11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_ 12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
13 13
14 #include <ApplicationServices/ApplicationServices.h> 14 #include <ApplicationServices/ApplicationServices.h>
15 15
16 #include "webrtc/modules/desktop_capture/window_capturer.h" 16 #include "webrtc/modules/desktop_capture/window_capturer.h"
17 #include "webrtc/system_wrappers/include/atomic32.h" 17 #include "webrtc/system_wrappers/include/atomic32.h"
18 #include "webrtc/system_wrappers/include/tick_util.h"
19 18
20 namespace webrtc { 19 namespace webrtc {
21 20
22 // This is a work around for the Chrome tab full-screen behavior: Chrome 21 // This is a work around for the Chrome tab full-screen behavior: Chrome
23 // creates a new window in full-screen mode to show a tab full-screen and 22 // creates a new window in full-screen mode to show a tab full-screen and
24 // minimizes the old window. To continue capturing in this case, we try to 23 // minimizes the old window. To continue capturing in this case, we try to
25 // find the new full-screen window using these criteria: 24 // find the new full-screen window using these criteria:
26 // 0. The original shared window is minimized. 25 // 0. The original shared window is minimized.
27 // 1. The original shared window's owner application name is "Google Chrome". 26 // 1. The original shared window's owner application name is "Google Chrome".
28 // 2. The original window and the new window have the same title and owner 27 // 2. The original window and the new window have the same title and owner
(...skipping 23 matching lines...) Expand all
52 ~FullScreenChromeWindowDetector(); 51 ~FullScreenChromeWindowDetector();
53 52
54 Atomic32 ref_count_; 53 Atomic32 ref_count_;
55 54
56 // We cache the last two results of the window list, so 55 // We cache the last two results of the window list, so
57 // |previous_window_list_| is taken at least 500ms before the next Capture() 56 // |previous_window_list_| is taken at least 500ms before the next Capture()
58 // call. If we only save the last result, we may get false positive (i.e. 57 // call. If we only save the last result, we may get false positive (i.e.
59 // full-screen window exists in the list) if Capture() is called too soon. 58 // full-screen window exists in the list) if Capture() is called too soon.
60 WindowCapturer::WindowList current_window_list_; 59 WindowCapturer::WindowList current_window_list_;
61 WindowCapturer::WindowList previous_window_list_; 60 WindowCapturer::WindowList previous_window_list_;
62 TickTime last_udpate_time_; 61 int64_t last_update_time_;
stefan-webrtc 2016/04/19 09:19:12 It'd be nice to add a unit to this member.
nisse-webrtc 2016/04/19 12:19:25 On a closer look, this member is unused. No explic
63 62
64 RTC_DISALLOW_COPY_AND_ASSIGN(FullScreenChromeWindowDetector); 63 RTC_DISALLOW_COPY_AND_ASSIGN(FullScreenChromeWindowDetector);
65 }; 64 };
66 65
67 } // namespace webrtc 66 } // namespace webrtc
68 67
69 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR _H_ 68 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698