Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1887773002:
remove googViewLimitedResolution stat (Closed)
|
Created:
4 years, 8 months ago by fippo Modified:
4 years ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionremove googViewLimitedResolution stat
adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore.
This was probably never implemented in videoengine2
BUG=webrtc:6870
Committed: https://crrev.com/ba7e71b53a959b27767e3bf147b61f0cb6139e03
Cr-Commit-Position: refs/heads/master@{#15546}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 30 (16 generated)
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG= ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG= ==========
philipp.hancke@googlemail.com changed reviewers: + tommi@webrtc.org
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887773002/1
tommi@webrtc.org changed reviewers: + hta@webrtc.org
hta - wdyt?
fippo and I chatted about this last night. We were unable to find any place that set this value. If that's true, it's a constant false, and it's a Goog-only constraint. Removing it seems like the Right Thing - if there are people who think they're getting this information and they're not getting it, breaking them now is better than breaking them later.
On 2016/04/14 08:23:48, hta-webrtc wrote: > fippo and I chatted about this last night. We were unable to find any place that > set this value. If that's true, it's a constant false, and it's a Goog-only > constraint. > > Removing it seems like the Right Thing - if there are people who think they're > getting this information and they're not getting it, breaking them now is better > than breaking them later. hey, I can send a PSA: email to discuss-webrtc to announce!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Since you signed up with your personal gmail, I guess you'll have to file a personal CLA... no escaping paperwork :-)
On 2016/04/15 10:44:18, hta-webrtc wrote: > lgtm > > Since you signed up with your personal gmail, I guess you'll have to file a > personal CLA... no escaping paperwork :-) I signed that loooong ago :-)
jansson@webrtc.org changed reviewers: + tommi@chromium.org
On 2016/04/15 10:48:49, fippo wrote: > On 2016/04/15 10:44:18, hta-webrtc wrote: > > lgtm > > > > Since you signed up with your personal gmail, I guess you'll have to file a > > personal CLA... no escaping paperwork :-) > > I signed that loooong ago :-) rebased after a small merge conflict.
The CQ bit was checked by tommi@webrtc.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org Link to the patchset: https://codereview.webrtc.org/1887773002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11284)
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG= ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 ==========
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 NOPRESUBMIT=true ==========
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 NOPRESUBMIT=true ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 ==========
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481545707219880,
"parent_rev": "08226497b9c61a1bfbd1fcd53e90b25b6fd4c7e2", "commit_rev":
"dcba178673c1bc4f7dc4c08fb1f95d94e8253887"}
Message was sent while issue was closed.
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 Review-Url: https://codereview.webrtc.org/1887773002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 Review-Url: https://codereview.webrtc.org/1887773002 ========== to ========== remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 Committed: https://crrev.com/ba7e71b53a959b27767e3bf147b61f0cb6139e03 Cr-Commit-Position: refs/heads/master@{#15546} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ba7e71b53a959b27767e3bf147b61f0cb6139e03 Cr-Commit-Position: refs/heads/master@{#15546} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
