Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 1885393002: Add histogram stats for jitter buffer delay and target delay for received video streams: (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 7 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add histogram stats for jitter buffer delay and current/target delay for received video streams: - "WebRTC.Video.JitterBufferDelayInMs" - "WebRTC.Video.TargetDelayInMs" (jitter delay + decode time + render delay) - "WebRTC.Video.CurrentDelayInMs" BUG= Committed: https://crrev.com/8688a4e2b53865cfd647a263f8685c3b6de8dacc Cr-Commit-Position: refs/heads/master@{#12539}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 5

Patch Set 4 : add stats for current delay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
åsapersson
4 years, 8 months ago (2016-04-14 12:23:41 UTC) #3
åsapersson
https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode185 webrtc/video/receive_statistics_proxy.cc:185: target_delay_counter_.Add(target_delay_ms); Let target delay stats replace metric below and ...
4 years, 8 months ago (2016-04-20 10:48:47 UTC) #5
stefan-webrtc
LG https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode85 webrtc/video/receive_statistics_proxy.cc:85: int target_delay_ms = target_delay_counter_.Avg(kMinRequiredDecodeSamples); We also have "current ...
4 years, 8 months ago (2016-04-26 08:19:26 UTC) #6
åsapersson
https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode85 webrtc/video/receive_statistics_proxy.cc:85: int target_delay_ms = target_delay_counter_.Avg(kMinRequiredDecodeSamples); On 2016/04/26 08:19:26, stefan-webrtc (holmer) ...
4 years, 8 months ago (2016-04-26 10:23:58 UTC) #8
stefan-webrtc
lgtm https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1885393002/diff/40001/webrtc/video/receive_statistics_proxy.cc#newcode185 webrtc/video/receive_statistics_proxy.cc:185: target_delay_counter_.Add(target_delay_ms); On 2016/04/26 10:23:58, åsapersson wrote: > On ...
4 years, 8 months ago (2016-04-26 10:39:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885393002/60001
4 years, 7 months ago (2016-04-27 12:10:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-04-27 14:10:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885393002/60001
4 years, 7 months ago (2016-04-28 06:40:40 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-28 06:42:39 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:05 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8688a4e2b53865cfd647a263f8685c3b6de8dacc
Cr-Commit-Position: refs/heads/master@{#12539}

Powered by Google App Engine
This is Rietveld 408576698