Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1883923005:
Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. (Closed)
|
Created:
4 years, 8 months ago by minyue-webrtc Modified:
4 years, 8 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionSuppress a flaky test: SwitchesToASTThenBackToTOFForVideo.
BUG=webrtc:5790
R=pbos@webrtc.org, stefan@webrtc.org
Committed: https://crrev.com/4aa438c91509cbfa9a240a66ea15f81c549d5525
Cr-Commit-Position: refs/heads/master@{#12378}
Patch Set 1 #
Total comments: 2
Patch Set 2 : revised #Messages
Total messages: 22 (11 generated)
Description was changed from ========== aaa BUG= ========== to ========== Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. BUG=webrtc:5790 ==========
minyue@webrtc.org changed reviewers: + pbos@webrtc.org
The CQ bit was checked by minyue@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883923005/1
Hi Peter, For the flaky test we saw, I made a CL to suppress it. Would you help review?
stefan@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm
lgtm with my nits fixed please put in the description that you're only disabling it under asan https://codereview.webrtc.org/1883923005/diff/1/webrtc/call/bitrate_estimator... File webrtc/call/bitrate_estimator_tests.cc (right): https://codereview.webrtc.org/1883923005/diff/1/webrtc/call/bitrate_estimator... webrtc/call/bitrate_estimator_tests.cc:305: // Crashes when run with ASan. See webrtc:5790. Not true, it fails, not crashes https://codereview.webrtc.org/1883923005/diff/1/webrtc/call/bitrate_estimator... webrtc/call/bitrate_estimator_tests.cc:306: #if defined(ADDRESS_SANITIZER) && defined(WEBRTC_LINUX) I don't think you need WEBRTC_LINUX here, we can disable it for asan everywhere
yes, fixed.
The CQ bit was checked by minyue@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org, stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/1883923005/#ps20001 (title: "revised")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883923005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by minyue@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883923005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. BUG=webrtc:5790 ========== to ========== Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. BUG=webrtc:5790 R=pbos@webrtc.org, stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4aa438c91509cbfa9a240a66e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 4aa438c91509cbfa9a240a66ea15f81c549d5525 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. BUG=webrtc:5790 R=pbos@webrtc.org, stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4aa438c91509cbfa9a240a66e... ========== to ========== Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. BUG=webrtc:5790 R=pbos@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/4aa438c91509cbfa9a240a66ea15f81c549d5525 Cr-Commit-Position: refs/heads/master@{#12378} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4aa438c91509cbfa9a240a66ea15f81c549d5525 Cr-Commit-Position: refs/heads/master@{#12378} |
