Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: webrtc/call/bitrate_estimator_tests.cc

Issue 1883923005: Suppress a flaky test: SwitchesToASTThenBackToTOFForVideo. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: revised Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/bitrate_estimator_tests.cc
diff --git a/webrtc/call/bitrate_estimator_tests.cc b/webrtc/call/bitrate_estimator_tests.cc
index c63d45dc6e695c26c801b206399c95584f95ed2a..4982fbfdadf6f008484db67dd0f8e1da1c3f34e3 100644
--- a/webrtc/call/bitrate_estimator_tests.cc
+++ b/webrtc/call/bitrate_estimator_tests.cc
@@ -302,7 +302,15 @@ TEST_F(BitrateEstimatorTest, SwitchesToASTForVideo) {
EXPECT_TRUE(receiver_log_.Wait());
}
-TEST_F(BitrateEstimatorTest, SwitchesToASTThenBackToTOFForVideo) {
+// Fails when run with ASan. See webrtc:5790.
+#if defined(ADDRESS_SANITIZER)
+#define MAYBE_SwitchesToASTThenBackToTOFForVideo \
+ DISABLED_SwitchesToASTThenBackToTOFForVideo
+#else
+#define MAYBE_SwitchesToASTThenBackToTOFForVideo \
+ SwitchesToASTThenBackToTOFForVideo
+#endif
+TEST_F(BitrateEstimatorTest, MAYBE_SwitchesToASTThenBackToTOFForVideo) {
video_send_config_.rtp.extensions.push_back(
RtpExtension(RtpExtension::kTOffset, kTOFExtensionId));
receiver_log_.PushExpectedLogLine(kSingleStreamLog);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698