Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1883543002: Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (Closed)

Created:
4 years, 8 months ago by ossu
Modified:
4 years, 8 months ago
Reviewers:
the sun, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (patchset #4 id:60001 of https://codereview.webrtc.org/1864993002/ ) Reason for revert: Broke import. Implementations of the old interface still exists somewhere. Original issue's description: > Remove the deprecated EncodeInternal interface from AudioEncoder > > Also hid MaxEncodedBytes by making it private. It will get removed as soon as subclasses have had time to remove their overrides. > > BUG=webrtc:5591 > > Committed: https://crrev.com/5222d315dbea8f3563c100cc9f2451907f70b05f > Cr-Commit-Position: refs/heads/master@{#12329} TBR=kwiberg@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5591 Committed: https://crrev.com/164bc4bbd3acae12e86bd386bffa68925a870034 Cr-Commit-Position: refs/heads/master@{#12330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -36 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 3 chunks +40 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 2 chunks +49 lines, -5 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/audio_encoder_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 3 chunks +36 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ossu
Created Revert of Remove the deprecated EncodeInternal interface from AudioEncoder
4 years, 8 months ago (2016-04-12 10:57:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883543002/1
4 years, 8 months ago (2016-04-12 10:57:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 10:58:10 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 10:58:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/164bc4bbd3acae12e86bd386bffa68925a870034
Cr-Commit-Position: refs/heads/master@{#12330}

Powered by Google App Engine
This is Rietveld 408576698