Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (patchset #4 id:60001 of https://codereview.webrtc.org/1864993002/ )
Reason for revert:
Broke import. Implementations of the old interface still exists somewhere.
Original issue's description:
> Remove the deprecated EncodeInternal interface from AudioEncoder
>
> Also hid MaxEncodedBytes by making it private. It will get removed as soon as subclasses have had time to remove their overrides.
>
> BUG=webrtc:5591
>
> Committed: https://crrev.com/5222d315dbea8f3563c100cc9f2451907f70b05f
> Cr-Commit-Position: refs/heads/master@{#12329}
TBR=kwiberg@webrtc.org,solenberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5591
Committed: https://crrev.com/164bc4bbd3acae12e86bd386bffa68925a870034
Cr-Commit-Position: refs/heads/master@{#12330}
Created Revert of Remove the deprecated EncodeInternal interface from AudioEncoder
4 years, 8 months ago
(2016-04-12 10:57:54 UTC)
#1
Created Revert of Remove the deprecated EncodeInternal interface from
AudioEncoder
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883543002/1
4 years, 8 months ago
(2016-04-12 10:57:59 UTC)
#2
4 years, 8 months ago
(2016-04-12 10:58:10 UTC)
#3
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (patchset ...
4 years, 8 months ago
(2016-04-12 10:58:13 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Revert of Remove the deprecated EncodeInternal interface from AudioEncoder
(patchset #4 id:60001 of https://codereview.webrtc.org/1864993002/ )
Reason for revert:
Broke import. Implementations of the old interface still exists somewhere.
Original issue's description:
> Remove the deprecated EncodeInternal interface from AudioEncoder
>
> Also hid MaxEncodedBytes by making it private. It will get removed as soon as
subclasses have had time to remove their overrides.
>
> BUG=webrtc:5591
>
> Committed: https://crrev.com/5222d315dbea8f3563c100cc9f2451907f70b05f
> Cr-Commit-Position: refs/heads/master@{#12329}
TBR=kwiberg@webrtc.org,solenberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5591
==========
to
==========
Revert of Remove the deprecated EncodeInternal interface from AudioEncoder
(patchset #4 id:60001 of https://codereview.webrtc.org/1864993002/ )
Reason for revert:
Broke import. Implementations of the old interface still exists somewhere.
Original issue's description:
> Remove the deprecated EncodeInternal interface from AudioEncoder
>
> Also hid MaxEncodedBytes by making it private. It will get removed as soon as
subclasses have had time to remove their overrides.
>
> BUG=webrtc:5591
>
> Committed: https://crrev.com/5222d315dbea8f3563c100cc9f2451907f70b05f
> Cr-Commit-Position: refs/heads/master@{#12329}
TBR=kwiberg@webrtc.org,solenberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5591
Committed: https://crrev.com/164bc4bbd3acae12e86bd386bffa68925a870034
Cr-Commit-Position: refs/heads/master@{#12330}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/164bc4bbd3acae12e86bd386bffa68925a870034 Cr-Commit-Position: refs/heads/master@{#12330}
4 years, 8 months ago
(2016-04-12 10:58:14 UTC)
#5
Issue 1883543002: Revert of Remove the deprecated EncodeInternal interface from AudioEncoder
(Closed)
Created 4 years, 8 months ago by ossu
Modified 4 years, 8 months ago
Reviewers: kwiberg-webrtc, the sun
Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Comments: 0