Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h

Issue 1883543002: Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h
diff --git a/webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h b/webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h
index f898877c190e3924ac8c41d4cc930a17d382ba52..58a1e756f971a013e9615630c6fd1df7adb2dfd7 100644
--- a/webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h
+++ b/webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h
@@ -18,11 +18,12 @@
namespace webrtc {
-class MockAudioEncoder : public AudioEncoder {
+class MockAudioEncoderBase : public AudioEncoder {
public:
- ~MockAudioEncoder() override { Die(); }
+ ~MockAudioEncoderBase() override { Die(); }
MOCK_METHOD0(Die, void());
MOCK_METHOD1(Mark, void(std::string desc));
+ MOCK_CONST_METHOD0(MaxEncodedBytes, size_t());
MOCK_CONST_METHOD0(SampleRateHz, int());
MOCK_CONST_METHOD0(NumChannels, size_t());
MOCK_CONST_METHOD0(RtpTimestampRateHz, int());
@@ -38,7 +39,10 @@
MOCK_METHOD1(SetTargetBitrate, void(int target_bps));
MOCK_METHOD1(SetMaxBitrate, void(int max_bps));
MOCK_METHOD1(SetMaxPayloadSize, void(int max_payload_size_bytes));
+};
+class MockAudioEncoder final : public MockAudioEncoderBase {
+ public:
// Note, we explicitly chose not to create a mock for the Encode method.
MOCK_METHOD3(EncodeImpl,
EncodedInfo(uint32_t timestamp,
@@ -85,6 +89,36 @@
AudioEncoder::EncodedInfo info_;
rtc::ArrayView<const uint8_t> payload_;
};
+
+};
+
+class MockAudioEncoderDeprecated final : public MockAudioEncoderBase {
+ public:
+ // Note, we explicitly chose not to create a mock for the Encode method.
+ MOCK_METHOD4(EncodeInternal,
+ EncodedInfo(uint32_t timestamp,
+ rtc::ArrayView<const int16_t> audio,
+ size_t max_encoded_bytes,
+ uint8_t* encoded));
+
+ // A functor like MockAudioEncoder::CopyEncoding above, but which has the
+ // deprecated Encode signature. Currently only used in one test and should be
+ // removed once that backwards compatibility is.
+ class CopyEncoding {
+ public:
+ CopyEncoding(AudioEncoder::EncodedInfo info,
+ rtc::ArrayView<const uint8_t> payload);
+
+ CopyEncoding(rtc::ArrayView<const uint8_t> payload);
+
+ AudioEncoder::EncodedInfo operator()(uint32_t timestamp,
+ rtc::ArrayView<const int16_t> audio,
+ size_t max_bytes_encoded,
+ uint8_t* encoded);
+ private:
+ AudioEncoder::EncodedInfo info_;
+ rtc::ArrayView<const uint8_t> payload_;
+ };
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698