Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: webrtc/video_frame.h

Issue 1881953002: Delete method webrtc::VideoFrame::native_handle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleanup TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video_frame.h
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h
index 28a6b8716d34eb57d0ed0aca4b58ba0c57cda7c1..87548b1a62452c350a7563221ec427c964e8e6fb 100644
--- a/webrtc/video_frame.h
+++ b/webrtc/video_frame.h
@@ -125,12 +125,17 @@ class VideoFrame {
// Return true if underlying plane buffers are of zero size, false if not.
bool IsZeroSize() const;
+ // TODO(nisse): Should be deleted, in favor of using the
magjed_webrtc 2016/04/13 08:53:23 Can't you update the place in Chrome first, and re
+ // corresponding method on the underlying VideoFrameBuffer. It's
+ // currently used in one place in Chrome.
+
// Return the handle of the underlying video frame. This is used when the
// frame is backed by a texture. The object should be destroyed when it is no
// longer in use, so the underlying resource can be freed.
void* native_handle() const;
- // Return the underlying buffer.
+ // Return the underlying buffer. Never nullptr for a properly
+ // initialized VideoFrame.
rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer() const;
// Set the underlying buffer.
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698