Chromium Code Reviews

Side by Side Diff: webrtc/video_frame.h

Issue 1881953002: Delete method webrtc::VideoFrame::native_handle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleanup TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 107 matching lines...)
118 void set_render_time_ms(int64_t render_time_ms) { 118 void set_render_time_ms(int64_t render_time_ms) {
119 render_time_ms_ = render_time_ms; 119 render_time_ms_ = render_time_ms;
120 } 120 }
121 121
122 // Get render time in miliseconds. 122 // Get render time in miliseconds.
123 int64_t render_time_ms() const { return render_time_ms_; } 123 int64_t render_time_ms() const { return render_time_ms_; }
124 124
125 // Return true if underlying plane buffers are of zero size, false if not. 125 // Return true if underlying plane buffers are of zero size, false if not.
126 bool IsZeroSize() const; 126 bool IsZeroSize() const;
127 127
128 // TODO(nisse): Should be deleted, in favor of using the
magjed_webrtc 2016/04/13 08:53:23 Can't you update the place in Chrome first, and re
129 // corresponding method on the underlying VideoFrameBuffer. It's
130 // currently used in one place in Chrome.
131
128 // Return the handle of the underlying video frame. This is used when the 132 // Return the handle of the underlying video frame. This is used when the
129 // frame is backed by a texture. The object should be destroyed when it is no 133 // frame is backed by a texture. The object should be destroyed when it is no
130 // longer in use, so the underlying resource can be freed. 134 // longer in use, so the underlying resource can be freed.
131 void* native_handle() const; 135 void* native_handle() const;
132 136
133 // Return the underlying buffer. 137 // Return the underlying buffer. Never nullptr for a properly
138 // initialized VideoFrame.
134 rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer() const; 139 rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer() const;
135 140
136 // Set the underlying buffer. 141 // Set the underlying buffer.
137 void set_video_frame_buffer( 142 void set_video_frame_buffer(
138 const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& buffer); 143 const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& buffer);
139 144
140 // Convert native-handle frame to memory-backed I420 frame. Should not be 145 // Convert native-handle frame to memory-backed I420 frame. Should not be
141 // called on a non-native-handle frame. 146 // called on a non-native-handle frame.
142 VideoFrame ConvertNativeToI420Frame() const; 147 VideoFrame ConvertNativeToI420Frame() const;
143 148
(...skipping 42 matching lines...)
186 uint8_t* _buffer; 191 uint8_t* _buffer;
187 size_t _length; 192 size_t _length;
188 size_t _size; 193 size_t _size;
189 bool _completeFrame = false; 194 bool _completeFrame = false;
190 AdaptReason adapt_reason_; 195 AdaptReason adapt_reason_;
191 int qp_ = -1; // Quantizer value. 196 int qp_ = -1; // Quantizer value.
192 }; 197 };
193 198
194 } // namespace webrtc 199 } // namespace webrtc
195 #endif // WEBRTC_VIDEO_FRAME_H_ 200 #endif // WEBRTC_VIDEO_FRAME_H_
OLDNEW
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine