Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1870283002: Don't reconfigure the encoder if the video options aren't changing. (Closed)

Created:
4 years, 8 months ago by Taylor Brandstetter
Modified:
4 years, 8 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@50
Target Ref:
refs/pending/branch-heads/50
Project:
webrtc
Visibility:
Public.

Description

Don't reconfigure the encoder if the video options aren't changing. Review URL: https://codereview.webrtc.org/1840043005 Cr-Commit-Position: refs/heads/master@{#12222} (cherry picked from commit 8ef0c11d69e94c9ebc39f30cf6702c38285ca1ca) BUG=chromium:598928 R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/302fb224a1b462b42d806a8b509122da89ad8142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
PTAL; this is a CL to merge this fix into M50. It looks like the ...
4 years, 8 months ago (2016-04-08 22:27:45 UTC) #2
pbos-webrtc
lgtm
4 years, 8 months ago (2016-04-11 09:47:36 UTC) #3
pbos-webrtc
Note that you can't merge this before you have merge approval in the bug though!
4 years, 8 months ago (2016-04-11 09:47:55 UTC) #4
Taylor Brandstetter
4 years, 8 months ago (2016-04-11 23:31:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
302fb224a1b462b42d806a8b509122da89ad8142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698