Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1840043005: Don't reconfigure the encoder if the video options aren't changing. (Closed)

Created:
4 years, 8 months ago by Taylor Brandstetter
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't reconfigure the encoder if the video options aren't changing. Committed: https://crrev.com/119760aa65cafca0d6178be954b56f4671d0013a Cr-Commit-Position: refs/heads/master@{#12222}

Patch Set 1 #

Patch Set 2 : removing whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M webrtc/media/base/mediachannel.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
This is pulled out of my larger CL. I know it might conflict slightly with ...
4 years, 8 months ago (2016-03-30 18:24:48 UTC) #2
nisse-webrtc
On 2016/03/30 18:24:48, Taylor Brandstetter wrote: > This is pulled out of my larger CL. ...
4 years, 8 months ago (2016-03-31 06:23:13 UTC) #3
pbos-webrtc
lgtm
4 years, 8 months ago (2016-04-04 12:05:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840043005/20001
4 years, 8 months ago (2016-04-04 17:46:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 18:43:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 18:43:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/119760aa65cafca0d6178be954b56f4671d0013a
Cr-Commit-Position: refs/heads/master@{#12222}

Powered by Google App Engine
This is Rietveld 408576698