Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1869523002:
GN: Fix some build errors for iOS. (Closed)
|
Created:
4 years, 8 months ago by kjellander_webrtc Modified:
4 years, 8 months ago Reviewers:
tkchin_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN: Fix some build errors for iOS.
With these changes, the only problem seem to be the missing jpeg
library. See https://codereview.chromium.org/1806503002/ for more details on that.
BUG=webrtc:5195, webrtc:5748
NOTRY=True
Committed: https://crrev.com/95177d1e71349cbb3dfa50c68a95e32041243488
Cr-Commit-Position: refs/heads/master@{#12273}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Added reference to bug 5748 #
Messages
Total messages: 14 (7 generated)
kjellander@webrtc.org changed reviewers: + tkchin@webrtc.org
https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... File webrtc/modules/audio_device/BUILD.gn (right): https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... webrtc/modules/audio_device/BUILD.gn:21: cflags = [ "-Wno-thread-safety-analysis" ] Zeke: do you think a bug should be filed for this, in case the error is something you want to take a look at? It looked like this: ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:156:3: error: cannot resolve lock expression [-Werror,-Wthread-safety-analysis] _crit.Enter(); ^~~~~ ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:163:7: error: cannot resolve lock expression [-Werror,-Wthread-safety-analysis] if (_crit.TryEnter()) { ^~~~~ ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:167:5: error: cannot resolve lock expression [-Werror,-Wthread-safety-analysis] _crit.Leave(); ^~~~~ ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:168:5: error: cannot resolve lock expression [-Werror,-Wthread-safety-analysis] _crit.Leave(); ^~~~~ 4 errors generated.
Description was changed from ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195 ========== to ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195 NOTRY=True ==========
On 2016/04/06 17:12:35, kjellander (webrtc) wrote: > https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... > File webrtc/modules/audio_device/BUILD.gn (right): > > https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... > webrtc/modules/audio_device/BUILD.gn:21: cflags = [ > "-Wno-thread-safety-analysis" ] > Zeke: do you think a bug should be filed for this, in case the error is > something you want to take a look at? > It looked like this: > > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:156:3: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Enter(); > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:163:7: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > if (_crit.TryEnter()) { > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:167:5: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Leave(); > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:168:5: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Leave(); > ^~~~~ > 4 errors generated. FYI, the failed run on ios64_gn_rel fails earlier than the mentioned jpeg library since it uses --check. The incorrect referenced headers will be addressed with the work of https://bugs.chromium.org/p/webrtc/issues/detail?id=4243 Also, there's a small BoringSSL error that I'm fixing in https://codereview.chromium.org/1868563002/
lgtm https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... File webrtc/modules/audio_device/BUILD.gn (right): https://codereview.webrtc.org/1869523002/diff/1/webrtc/modules/audio_device/B... webrtc/modules/audio_device/BUILD.gn:21: cflags = [ "-Wno-thread-safety-analysis" ] On 2016/04/06 17:12:35, kjellander (webrtc) wrote: > Zeke: do you think a bug should be filed for this, in case the error is > something you want to take a look at? > It looked like this: > > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:156:3: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Enter(); > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:163:7: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > if (_crit.TryEnter()) { > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:167:5: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Leave(); > ^~~~~ > ../../webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:168:5: error: > cannot resolve lock expression [-Werror,-Wthread-safety-analysis] > _crit.Leave(); > ^~~~~ > 4 errors generated. File a bug. Should be suppressed manually in the implementation file. These warnings are benign. https://codereview.webrtc.org/1869523002/diff/1/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/1869523002/diff/1/webrtc/test/BUILD.gn#newcode81 webrtc/test/BUILD.gn:81: cflags = [ "-fobjc-arc" ] # CLANG_ENABLE_OBJC_ARC = YES. this should be added globally somewhere I think for ios targets maybe an ios_config somewhere we can use?
Description was changed from ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195 NOTRY=True ========== to ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195, webrtc:5748 NOTRY=True ==========
https://codereview.webrtc.org/1869523002/diff/1/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/1869523002/diff/1/webrtc/test/BUILD.gn#newcode81 webrtc/test/BUILD.gn:81: cflags = [ "-fobjc-arc" ] # CLANG_ENABLE_OBJC_ARC = YES. On 2016/04/06 19:23:17, tkchin_webrtc wrote: > this should be added globally somewhere I think for ios targets > maybe an ios_config somewhere we can use? That's probably a good idea, but let's do it in another CL. Is there no case when it's not preferred to have it for iOS?
The CQ bit was checked by kjellander@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1869523002/#ps20001 (title: "Added reference to bug 5748")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869523002/20001
Message was sent while issue was closed.
Description was changed from ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195, webrtc:5748 NOTRY=True ========== to ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195, webrtc:5748 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195, webrtc:5748 NOTRY=True ========== to ========== GN: Fix some build errors for iOS. With these changes, the only problem seem to be the missing jpeg library. See https://codereview.chromium.org/1806503002/ for more details on that. BUG=webrtc:5195, webrtc:5748 NOTRY=True Committed: https://crrev.com/95177d1e71349cbb3dfa50c68a95e32041243488 Cr-Commit-Position: refs/heads/master@{#12273} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/95177d1e71349cbb3dfa50c68a95e32041243488 Cr-Commit-Position: refs/heads/master@{#12273} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
