Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/modules/audio_device/BUILD.gn

Issue 1869523002: GN: Fix some build errors for iOS. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added reference to bug 5748 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/BUILD.gn
diff --git a/webrtc/modules/audio_device/BUILD.gn b/webrtc/modules/audio_device/BUILD.gn
index f41501e7f8446a9445155c1ddb714583fcd892fe..198b67d52008e8514ef773afd2c8771c777dc831 100644
--- a/webrtc/modules/audio_device/BUILD.gn
+++ b/webrtc/modules/audio_device/BUILD.gn
@@ -14,6 +14,14 @@ config("audio_device_config") {
"include",
"dummy", # Contains dummy audio device implementations.
]
+ if (is_ios) {
+ # GN orders flags on a target before flags from configs. In order to be able
+ # suppress the -Wthread-safety-analysis warning, it has come from a config
+ # and can't be on the target directly.
+ # TODO(tkchin): Remove after fixing
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5748
+ cflags = [ "-Wno-thread-safety-analysis" ]
+ }
}
source_set("audio_device") {
@@ -148,6 +156,7 @@ source_set("audio_device") {
"ios/voice_processing_audio_unit.mm",
]
cflags += [ "-fobjc-arc" ] # CLANG_ENABLE_OBJC_ARC = YES.
+
libs = [
"AudioToolbox.framework",
"AVFoundation.framework",
« no previous file with comments | « no previous file | webrtc/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698