Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1862123002: Restore BoringSSL behavior for webrtc/base/BUILD.gn (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restore BoringSSL behavior for webrtc/base/BUILD.gn In https://codereview.webrtc.org/1857163003 the openssl* sources and the dependency on BoringSSL was moved out of the use_openssl condition to make it similar to the GYP build. Unfortunately this had unexpected side effects for the Chromium build. See the referenced bug for more details. This CL also fixes an incorrect move of the :ios_config dependency that was spotted in https://codereview.webrtc.org/1857163003. BUG=chromium:601042 R=perkj@webrtc.org, torbjorng@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d31b664a6cfc550fbadf551edc27e774f6177c1b

Patch Set 1 #

Patch Set 2 : Restored ios_config dependency as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M webrtc/base/BUILD.gn View 1 4 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Please have a look. This should unblock rolling into Chromium.
4 years, 8 months ago (2016-04-06 15:02:16 UTC) #3
torbjorng (webrtc)
lgtm
4 years, 8 months ago (2016-04-06 15:11:53 UTC) #4
perkj_webrtc
On 2016/04/06 15:11:53, torbjorng (webrtc) wrote: > lgtm lgtm
4 years, 8 months ago (2016-04-06 15:16:15 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d31b664a6cfc550fbadf551edc27e774f6177c1b Cr-Commit-Position: refs/heads/master@{#12264}
4 years, 8 months ago (2016-04-06 15:18:56 UTC) #7
kjellander_webrtc
4 years, 8 months ago (2016-04-06 15:19:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d31b664a6cfc550fbadf551edc27e774f6177c1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698