Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1857163003: Reland of Cleanup webrtc/base/base.gyp (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Cleanup webrtc/base/base.gyp (patchset #1 id:1 of https://codereview.webrtc.org/1856323003/ ) Reason for revert: Creating template CL for reland Original issue's description: > Revert of Cleanup webrtc/base/base.gyp (patchset #2 id:80001 of https://codereview.webrtc.org/1859803002/ ) > > Reason for revert: > For some odd reason this breaks chromium.webrtc.fyi bots: > ../../third_party/webrtc_overrides/webrtc/base/win32socketinit.cc:13:2: error: "Only compile this on Windows" > #error "Only compile this on Windows" > ^ > 1 error generated. > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/11515/steps/compile/logs/stdio > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4650/steps/compile/logs/stdio > > Original issue's description: > > Cleanup webrtc/base/base.gyp > > > > * Remove all source exclusions since they make the file very hard to > > read and heavily increases the risk for mistakes. > > * Don't compile the openssl* sources if use_openssl==0. > > * Move platform specific sources into conditional includes to make it > > easier to verify a 1:1 mapping with BUILD.gn (since GN doesn't support > > automatic detection of platform specific sources based on filenames). > > * Add missing sources for the GN build. > > * Reorder some blocks to make GYP vs GN mapping match. > > > > BUG=webrtc:4256 > > R=perkj@webrtc.org, torbjorng@webrtc.org > > > > Committed: https://crrev.com/47f33cb28ffb0fa0f053ae0aa0086e11f85bf444 > > Cr-Commit-Position: refs/heads/master@{#12235} > > TBR=perkj@webrtc.org,torbjorng@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:4256 > NOTRY=True > > Committed: https://crrev.com/c8587ad92d394bfb60498df1209a3beb9017e001 > Cr-Commit-Position: refs/heads/master@{#12237} TBR=perkj@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Committed: https://crrev.com/a8a7ef6cf027c8170a6ff4ed6e6c9eb4ee309c1b Cr-Commit-Position: refs/heads/master@{#12242}

Patch Set 1 : Pristine copy #

Patch Set 2 : Removed .pump files and moved win32socketinit.cc into Win-condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -282 lines) Patch
M webrtc/base/BUILD.gn View 1 16 chunks +49 lines, -66 lines 0 comments Download
M webrtc/base/base.gyp View 1 19 chunks +109 lines, -216 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
Created Reland of Cleanup webrtc/base/base.gyp
4 years, 8 months ago (2016-04-05 13:50:40 UTC) #1
kjellander_webrtc
On 2016/04/05 13:50:40, kjellander (webrtc) wrote: > Created Reland of Cleanup webrtc/base/base.gyp This one shouldn't ...
4 years, 8 months ago (2016-04-05 15:13:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857163003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857163003/70001
4 years, 8 months ago (2016-04-05 15:13:27 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 8 months ago (2016-04-05 15:13:35 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 15:13:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8a7ef6cf027c8170a6ff4ed6e6c9eb4ee309c1b
Cr-Commit-Position: refs/heads/master@{#12242}

Powered by Google App Engine
This is Rietveld 408576698