Added a query function for whether submodules are enabled

Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
Committed: https://crrev.com/dc2242d351c908ac86811c5c9b83a573d98cb717
Cr-Commit-Position: refs/heads/master@{#12266}

[peah-webrtc, 2016-04-05 21:00:27]

Description was changed from

==========
Added a query function for whether submodules are enabled that can be called
from the render side without making APM singlethreaded

BUG=
==========

to

==========
Added a query function for whether submodules are enabled that can be called
from the render side without making APM singlethreaded.

This CL is addressing the problems with high render-side call duration that were
triggered by the CL https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[peah-webrtc, 2016-04-05 21:00:27]

Description was changed from

==========
Added a query function for whether submodules are enabled that can be called
from the render side without making APM singlethreaded

BUG=
==========

to

==========
Added a query function for whether submodules are enabled that can be called
from the render side without making APM singlethreaded.

This CL is addressing the problems with high render-side call duration that were
triggered by the CL https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[peah-webrtc, 2016-04-05 21:00:27]

peah@webrtc.org changed reviewers:
+ aluebs@webrtc.org, henrik.lundin@webrtc.org, solenberg@webrtc.org

[peah-webrtc, 2016-04-05 21:00:27]

peah@webrtc.org changed reviewers:
+ aluebs@webrtc.org, henrik.lundin@webrtc.org, solenberg@webrtc.org

[peah-webrtc, 2016-04-05 21:01:00]

Description was changed from

==========
Added a query function for whether submodules are enabled that can be called
from the render side without making APM singlethreaded.

This CL is addressing the problems with high render-side call duration that were
triggered by the CL https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

to

==========
Added a query function for whether submodules are enabled
 that can be called from the render side without making APM singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[peah-webrtc, 2016-04-05 21:01:23]

Description was changed from

==========
Added a query function for whether submodules are enabled
 that can be called from the render side without making APM singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

to

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[peah-webrtc, 2016-04-05 21:03:46]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 21:03:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859243002/1

[aluebs-webrtc, 2016-04-05 21:26:06]

lgtm
Thank you for doing this! :)
Maybe it is a silly question, but why do we need an accesser that captures each
crit_*? Can't we have one that doesn't capture any?

[peah-webrtc, 2016-04-05 23:05:36]

On 2016/04/05 21:26:06, aluebs-webrtc wrote:
> lgtm
> Thank you for doing this! :)
> Maybe it is a silly question, but why do we need an accesser that captures
each
> crit_*? Can't we have one that doesn't capture any?

Since the resource (variable enabled_) may be modified at any point while being
accessed concurrently there must be locks that prevents the resource to be read
while it is written.

[peah-webrtc, 2016-04-05 23:05:58]

Description was changed from

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

to

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL 
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[aluebs-webrtc, 2016-04-05 23:06:47]

On 2016/04/05 23:05:36, peah-webrtc wrote:
> On 2016/04/05 21:26:06, aluebs-webrtc wrote:
> > lgtm
> > Thank you for doing this! :)
> > Maybe it is a silly question, but why do we need an accesser that captures
> each
> > crit_*? Can't we have one that doesn't capture any?
> 
> Since the resource (variable enabled_) may be modified at any point while
being
> accessed concurrently there must be locks that prevents the resource to be
read
> while it is written.

I see, thank you for clarifying that.

[commit-bot: I haz the power, 2016-04-05 23:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 23:14:48]

Dry run: This issue passed the CQ dry run.

[the sun, 2016-04-06 08:42:17]

lgtm

[hlundin-webrtc, 2016-04-06 11:12:11]

lgtm

[peah-webrtc, 2016-04-06 11:27:42]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-04-06 11:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, henrik.lundin@webrtc.org, aluebs@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1859243002/#ps20001 (title:
""Rebase with latest master"")

[commit-bot: I haz the power, 2016-04-06 11:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859243002/20001

[peah-webrtc, 2016-04-06 11:29:50]

The CQ bit was unchecked by peah@webrtc.org

[peah-webrtc, 2016-04-06 11:31:33]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-04-06 11:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859243002/20001

[commit-bot: I haz the power, 2016-04-06 13:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 13:28:35]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-04-06 14:06:34]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-04-06 14:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859243002/20001

[commit-bot: I haz the power, 2016-04-06 16:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 16:07:22]

Exceeded global retry quota

[peah-webrtc, 2016-04-06 16:25:53]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-04-06 16:26:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859243002/20001

[commit-bot: I haz the power, 2016-04-06 16:31:02]

Description was changed from

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL 
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

to

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL 
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

[commit-bot: I haz the power, 2016-04-06 16:31:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 16:31:16]

Description was changed from

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side 
call duration that were triggered by the CL 
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736
==========

to

==========
Added a query function for whether submodules are enabled
that can be called from the render side without making APM
singlethreaded.

This CL is addressing the problems with high render-side
call duration that were triggered by the CL
https://codereview.webrtc.org/1844583003

BUG=webrtc:5736

Committed: https://crrev.com/dc2242d351c908ac86811c5c9b83a573d98cb717
Cr-Commit-Position: refs/heads/master@{#12266}
==========

[commit-bot: I haz the power, 2016-04-06 16:31:17]

Patchset 2 (id:??) landed as
https://crrev.com/dc2242d351c908ac86811c5c9b83a573d98cb717
Cr-Commit-Position: refs/heads/master@{#12266}