webrtc/modules/audio_processing/echo_cancellation_impl.h - Issue 1859243002: Added a query function for whether submodules are enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1859243002: Added a query function for whether submodules are enabled (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: "Rebase with latest master" Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/echo_cancellation_impl.h

diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h

index b91d23d823efc99a560bba4e31cae087a51f5658..813019f424c1dbecdce5539e0730502187b24567 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h

+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h

@@ -48,6 +48,11 @@ class EchoCancellationImpl : public EchoCancellation {

bool is_extended_filter_enabled() const;

bool is_aec3_enabled() const;

+ // Checks whether the module is enabled. Must only be

+ // called from the render side of APM as otherwise

+ // deadlocks may occur.

+ bool is_enabled_render_side_query() const;

// Reads render side data that has been queued on the render call.

// Called holding the capture lock.

void ReadQueuedRenderData();