Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1858123003: Reland of Moved ring-buffer related files from common_audio to audio_processing" (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Moved ring-buffer related files from common_audio to audio_processing (patchset #8 id:150001 of https://codereview.webrtc.org/1846903004/ )" This reverts commit c54aad6ae07fe2a44a65be403386bd7d7d865e5b. BUG=webrtc:5724 NOPRESUBMIT=true Committed: https://crrev.com/8864fe5e08f8d8711612526dee9a812adfcd3be1 Cr-Commit-Position: refs/heads/master@{#12247}

Patch Set 1 #

Patch Set 2 : Added temporary headers with forwarded includes to solve downstream dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1876 lines) Patch
M webrtc/common_audio/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/common_audio/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer.h View 1 2 chunks +3 lines, -42 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/common_audio/blocker.h View 1 1 chunk +17 lines, -124 lines 0 comments Download
D webrtc/common_audio/blocker.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D webrtc/common_audio/blocker_unittest.cc View 1 chunk +0 lines, -345 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 1 4 chunks +0 lines, -9 lines 0 comments Download
D webrtc/common_audio/lapped_transform.h View 1 2 chunks +3 lines, -111 lines 0 comments Download
D webrtc/common_audio/lapped_transform.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/common_audio/lapped_transform_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D webrtc/common_audio/ring_buffer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/common_audio/ring_buffer.c View 1 chunk +0 lines, -247 lines 0 comments Download
D webrtc/common_audio/ring_buffer_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_c.c View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/echo_control_mobile.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer.c View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
peah-webrtc
Since there were downstream dependencies, the CL https://codereview.webrtc.org/1846903004/ needed to be reverted. This CL relands ...
4 years, 8 months ago (2016-04-05 07:49:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858123003/20001
4 years, 8 months ago (2016-04-05 08:41:10 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4593)
4 years, 8 months ago (2016-04-05 08:46:26 UTC) #7
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-05 09:10:29 UTC) #8
ivoc
On 2016/04/05 09:10:29, hlundin-webrtc wrote: > lgtm lgtm.
4 years, 8 months ago (2016-04-05 13:59:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858123003/20001
4 years, 8 months ago (2016-04-05 21:03:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4616)
4 years, 8 months ago (2016-04-05 21:10:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858123003/20001
4 years, 8 months ago (2016-04-05 21:42:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 21:42:52 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8864fe5e08f8d8711612526dee9a812adfcd3be1 Cr-Commit-Position: refs/heads/master@{#12247}
4 years, 8 months ago (2016-04-05 21:42:59 UTC) #20
peah-webrtc
4 years, 8 months ago (2016-04-05 21:57:32 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1855393004/ by peah@webrtc.org.

The reason for reverting is: Because of down-stream dependencies, this CL needs
to be reverted.

The dependencies will be resolved and then the CL will be relanded..

Powered by Google App Engine
This is Rietveld 408576698