Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1851873003: Moved the ringbuffer to be built using C++ (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@MoveRingBuffer_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved the ringbuffer to be built using C++ BUG=webrtc:5724 Committed: https://crrev.com/677e5774eaf287fa02f75fd5c8ad3f9ded9ed9c4 Cr-Commit-Position: refs/heads/master@{#12230}

Patch Set 1 : Changed filename to .cc, changed buildfiles and removed extern includes #

Patch Set 2 : Fixed warnings reported by cl upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -268 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/utility/ring_buffer.c View 1 chunk +0 lines, -247 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer.cc View 1 8 chunks +13 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (9 generated)
peah-webrtc
4 years, 8 months ago (2016-04-01 21:21:58 UTC) #3
kwiberg-webrtc
lgtm But "buffer" doesn't have that many g's in it. :-) Also, it'd be *so* ...
4 years, 8 months ago (2016-04-02 01:17:25 UTC) #5
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-04 07:19:55 UTC) #7
ivoc
LGTM
4 years, 8 months ago (2016-04-04 07:21:41 UTC) #8
peah-webrtc
On 2016/04/04 07:21:41, ivoc wrote: > LGTM Thanks for pointing out the type! :-) Sorry ...
4 years, 8 months ago (2016-04-04 07:31:51 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1846903004 Patch 110001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-04 07:32:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851873003/20001
4 years, 8 months ago (2016-04-05 06:02:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 06:58:07 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/677e5774eaf287fa02f75fd5c8ad3f9ded9ed9c4 Cr-Commit-Position: refs/heads/master@{#12230}
4 years, 8 months ago (2016-04-05 06:58:27 UTC) #18
peah-webrtc
4 years, 8 months ago (2016-04-05 07:00:29 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1858873003/ by peah@webrtc.org.

The reason for reverting is: This CL is dependent on the  CL
https://codereview.webrtc.org/1846903004/ which caused a google3 breakage due to
dependencies in Google3.

I will fix that, and reland this CL..

Powered by Google App Engine
This is Rietveld 408576698