Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 1846903004: Moved ring-buffer related files from common_audio to audio_processing (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved ring-buffer related files from common_audio to audio_processing BUG=webrtc:5724 NOPRESUBMIT=true Committed: https://crrev.com/711ccc8d96490f58cc3d7fd9207c19d4d881d4dc Cr-Commit-Position: refs/heads/master@{#12227}

Patch Set 1 : Moving files #

Patch Set 2 : Corrected inclusion guard names #

Patch Set 3 : Added missing include #

Patch Set 4 : Applied git CL format #

Patch Set 5 : Corrected order of includes #

Total comments: 2

Patch Set 6 : Reverted running git cl format #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1906 lines) Patch
M webrtc/common_audio/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer.h View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/common_audio/audio_ring_buffer_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/common_audio/blocker.h View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/common_audio/blocker.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D webrtc/common_audio/blocker_unittest.cc View 1 chunk +0 lines, -345 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 4 chunks +0 lines, -12 lines 0 comments Download
D webrtc/common_audio/lapped_transform.h View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/common_audio/lapped_transform.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/common_audio/lapped_transform_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D webrtc/common_audio/ring_buffer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/common_audio/ring_buffer.c View 1 chunk +0 lines, -247 lines 0 comments Download
D webrtc/common_audio/ring_buffer_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_c.c View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/echo_control_mobile.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer.cc View 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc View 1 2 4 5 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker.cc View 4 5 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/blocker_unittest.cc View 4 5 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform.h View 1 4 5 2 chunks +4 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform.cc View 4 5 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/lapped_transform_unittest.cc View 4 5 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer.h View 1 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer.c View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/utility/ring_buffer_unittest.cc View 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (18 generated)
peah-webrtc
4 years, 8 months ago (2016-04-01 09:19:11 UTC) #4
ivoc
LGTM
4 years, 8 months ago (2016-04-01 09:30:15 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903004/100001
4 years, 8 months ago (2016-04-01 09:31:05 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4544)
4 years, 8 months ago (2016-04-01 09:38:33 UTC) #11
hlundin-webrtc
Please, consider not clang-formatting the files you moved. https://codereview.webrtc.org/1846903004/diff/100001/webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc File webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc (right): https://codereview.webrtc.org/1846903004/diff/100001/webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc#newcode76 webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc:76: ReadAndWriteTest(input, ...
4 years, 8 months ago (2016-04-01 10:54:39 UTC) #12
peah-webrtc
On 2016/04/01 10:54:39, hlundin-webrtc wrote: > Please, consider not clang-formatting the files you moved. > ...
4 years, 8 months ago (2016-04-01 14:46:50 UTC) #13
peah-webrtc
I have now reverted the effect of running git cl format. Please feel free to ...
4 years, 8 months ago (2016-04-01 20:53:18 UTC) #14
peah-webrtc
https://codereview.webrtc.org/1846903004/diff/100001/webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc File webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc (right): https://codereview.webrtc.org/1846903004/diff/100001/webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc#newcode76 webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc:76: ReadAndWriteTest(input, ::testing::get<0>(GetParam()), On 2016/04/01 10:54:39, hlundin-webrtc wrote: > Could ...
4 years, 8 months ago (2016-04-01 20:54:39 UTC) #15
hlundin-webrtc
Much better! LGTM.
4 years, 8 months ago (2016-04-04 07:12:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903004/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903004/110001
4 years, 8 months ago (2016-04-04 07:36:45 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4574)
4 years, 8 months ago (2016-04-04 07:46:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903004/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903004/130001
4 years, 8 months ago (2016-04-04 15:53:36 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4581)
4 years, 8 months ago (2016-04-04 16:01:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903004/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903004/150001
4 years, 8 months ago (2016-04-05 05:57:24 UTC) #30
commit-bot: I haz the power
Committed patchset #8 (id:150001)
4 years, 8 months ago (2016-04-05 05:57:49 UTC) #32
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/711ccc8d96490f58cc3d7fd9207c19d4d881d4dc Cr-Commit-Position: refs/heads/master@{#12227}
4 years, 8 months ago (2016-04-05 05:57:56 UTC) #34
peah-webrtc
4 years, 8 months ago (2016-04-05 07:02:08 UTC) #35
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:150001) has been created in
https://codereview.webrtc.org/1856323002/ by peah@webrtc.org.

The reason for reverting is: This CL caused a google3 breakage due to
dependencies in Google3.

I will fix that, and reland..

Powered by Google App Engine
This is Rietveld 408576698