Remove the dead code in Transport::ConnectChannels

Remove the if condition block in the function Transport::ConnectChannels. It will not be triggered anymore.

Committed: https://crrev.com/3ba4d533795655745c201b9d2515705112baa32f
Cr-Commit-Position: refs/heads/master@{#12321}

[Zhi Huang, 2016-03-30 22:12:08]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2016-03-30 22:12:09]

The CQ bit was unchecked by zhihuang@webrtc.org

[Zhi Huang, 2016-03-30 22:12:15]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2016-03-30 22:12:16]

The CQ bit was unchecked by zhihuang@webrtc.org

[Zhi Huang, 2016-03-31 22:45:20]

Description was changed from

==========
remove the dead code in ConnectChannel

BUG=
==========

to

==========
Remove the if condition block in the function Transport::ConnectChannels. It
will not be triggered anymore.
==========

[Zhi Huang, 2016-03-31 22:48:18]

zhihuang@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-04-01 00:43:08]

https://codereview.webrtc.org/1844133002/diff/20001/webrtc/p2p/base/transport.cc
File webrtc/p2p/base/transport.cc (left):

https://codereview.webrtc.org/1844133002/diff/20001/webrtc/p2p/base/transport...
webrtc/p2p/base/transport.cc:245: 
Can you add "RTC_DCHECK(local_description_ != nullptr);"?

[Zhi Huang, 2016-04-04 18:04:15]

On 2016/04/01 00:43:08, Taylor Brandstetter wrote:
>
https://codereview.webrtc.org/1844133002/diff/20001/webrtc/p2p/base/transport.cc
> File webrtc/p2p/base/transport.cc (left):
> 
>
https://codereview.webrtc.org/1844133002/diff/20001/webrtc/p2p/base/transport...
> webrtc/p2p/base/transport.cc:245: 
> Can you add "RTC_DCHECK(local_description_ != nullptr);"?

Done.

local description is set for FakeTransport in TransportTest.TestGetStats.

[Taylor Brandstetter, 2016-04-05 21:54:34]

lgtm

[pthatcher1, 2016-04-11 19:41:03]

lgtm

https://codereview.webrtc.org/1844133002/diff/60001/webrtc/p2p/base/transport.cc
File webrtc/p2p/base/transport.cc (right):

https://codereview.webrtc.org/1844133002/diff/60001/webrtc/p2p/base/transport...
webrtc/p2p/base/transport.cc:230: RTC_DCHECK(local_description_ != nullptr);
RTC_DCHECK(local_description_) is enough.

[Zhi Huang, 2016-04-11 21:31:14]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2016-04-11 21:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1844133002/#ps80001 (title:
"Small modification of null check")

[commit-bot: I haz the power, 2016-04-11 21:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844133002/80001

[commit-bot: I haz the power, 2016-04-11 22:10:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-11 22:11:05]

Description was changed from

==========
Remove the if condition block in the function Transport::ConnectChannels. It
will not be triggered anymore.
==========

to

==========
Remove the if condition block in the function Transport::ConnectChannels. It
will not be triggered anymore.

Committed: https://crrev.com/3ba4d533795655745c201b9d2515705112baa32f
Cr-Commit-Position: refs/heads/master@{#12321}
==========

[commit-bot: I haz the power, 2016-04-11 22:11:06]

Patchset 5 (id:??) landed as
https://crrev.com/3ba4d533795655745c201b9d2515705112baa32f
Cr-Commit-Position: refs/heads/master@{#12321}