Remove the dead code in Transport::ConnectChannels

webrtc/p2p/base/transport.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 209 matching lines @@
   channels_.erase(iter);
   DestroyTransportChannel(channel);
 }
 
 void Transport::ConnectChannels() {
   if (connect_requested_ || channels_.empty())
     return;
 
   connect_requested_ = true;
 
-  if (!local_description_) {
-    // TOOD(mallinath) : TransportDescription(TD) shouldn't be generated here.
-    // As Transport must know TD is offer or answer and cricket::Transport
-    // doesn't have the capability to decide it. This should be set by the
-    // Session.
-    // Session must generate local TD before remote candidates pushed when
-    // initiate request initiated by the remote.
-    LOG(LS_INFO) << "Transport::ConnectChannels: No local description has "
-                 << "been set. Will generate one.";
-    TransportDescription desc(std::vector<std::string>(),
-                              rtc::CreateRandomString(ICE_UFRAG_LENGTH),
-                              rtc::CreateRandomString(ICE_PWD_LENGTH),
-                              ICEMODE_FULL, CONNECTIONROLE_NONE, nullptr);
-    SetLocalTransportDescription(desc, CA_OFFER, nullptr);
-  }
-

[Taylor Brandstetter, 2016/04/01 00:43:07]

Can you add "RTC_DCHECK(local_description_ != nullptr);"?

   CallChannels(&TransportChannelImpl::Connect);
 }
 
 void Transport::MaybeStartGathering() {
   if (connect_requested_) {
     CallChannels(&TransportChannelImpl::MaybeStartGathering);
   }
 }
 
 void Transport::DestroyAllChannels() {
@@ skipping 152 matching lines @@
   // negotiation happens.
   for (const auto& kv : channels_) {
     if (!ApplyNegotiatedTransportDescription(kv.second, error_desc)) {
       return false;
     }
   }
   return true;
 }
 
 }  // namespace cricket