Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1843413002: Delete unused cricket::VideoFrame methods MakeExclusive and CopyToFrame. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused cricket::VideoFrame methods MakeExclusive and CopyToFrame. BUG=webrtc:5682 Committed: https://crrev.com/60083c86fa0465dd7e534afbc2bd42458b4c1161 Cr-Commit-Position: refs/heads/master@{#12188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCI420Frame.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nisse-webrtc
MakeExclusive usage was eliminated from Chrome the other day. So we can now delete it ...
4 years, 8 months ago (2016-03-31 08:31:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843413002/1
4 years, 8 months ago (2016-03-31 08:45:10 UTC) #4
perkj_webrtc
lgtm
4 years, 8 months ago (2016-03-31 08:51:18 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-03-31 10:45:52 UTC) #7
pbos-webrtc
lgtm
4 years, 8 months ago (2016-03-31 14:39:04 UTC) #8
tkchin_webrtc
lgtm
4 years, 8 months ago (2016-03-31 15:44:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843413002/1
4 years, 8 months ago (2016-04-01 06:31:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 06:32:45 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 06:32:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60083c86fa0465dd7e534afbc2bd42458b4c1161
Cr-Commit-Position: refs/heads/master@{#12188}

Powered by Google App Engine
This is Rietveld 408576698