Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Side by Side Diff: webrtc/media/base/videoframe.h

Issue 1843413002: Delete unused cricket::VideoFrame methods MakeExclusive and CopyToFrame. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/objc/public/RTCI420Frame.h ('k') | webrtc/media/base/videoframe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 // Make a shallow copy of the frame. The frame buffer itself is not copied. 82 // Make a shallow copy of the frame. The frame buffer itself is not copied.
83 // Both the current and new VideoFrame will share a single reference-counted 83 // Both the current and new VideoFrame will share a single reference-counted
84 // frame buffer. 84 // frame buffer.
85 virtual VideoFrame *Copy() const = 0; 85 virtual VideoFrame *Copy() const = 0;
86 86
87 // Since VideoFrame supports shallow copy and the internal frame buffer might 87 // Since VideoFrame supports shallow copy and the internal frame buffer might
88 // be shared, this function can be used to check exclusive ownership. 88 // be shared, this function can be used to check exclusive ownership.
89 virtual bool IsExclusive() const = 0; 89 virtual bool IsExclusive() const = 0;
90 90
91 // In case VideoFrame needs exclusive access of the frame buffer, user can
92 // call MakeExclusive() to make sure the frame buffer is exclusively
93 // accessible to the current object. This might mean a deep copy of the frame
94 // buffer if it is currently shared by other objects.
95 virtual bool MakeExclusive() = 0;
96
97 // Writes the frame into the target VideoFrame.
98 virtual void CopyToFrame(VideoFrame* target) const;
99
100 // Return a copy of frame which has its pending rotation applied. The 91 // Return a copy of frame which has its pending rotation applied. The
101 // ownership of the returned frame is held by this frame. 92 // ownership of the returned frame is held by this frame.
102 virtual const VideoFrame* GetCopyWithRotationApplied() const = 0; 93 virtual const VideoFrame* GetCopyWithRotationApplied() const = 0;
103 94
104 // Converts the I420 data to RGB of a certain type such as ARGB and ABGR. 95 // Converts the I420 data to RGB of a certain type such as ARGB and ABGR.
105 // Returns the frame's actual size, regardless of whether it was written or 96 // Returns the frame's actual size, regardless of whether it was written or
106 // not (like snprintf). Parameters size and stride_rgb are in units of bytes. 97 // not (like snprintf). Parameters size and stride_rgb are in units of bytes.
107 // If there is insufficient space, nothing is written. 98 // If there is insufficient space, nothing is written.
108 virtual size_t ConvertToRgbBuffer(uint32_t to_fourcc, 99 virtual size_t ConvertToRgbBuffer(uint32_t to_fourcc,
109 uint8_t* buffer, 100 uint8_t* buffer,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 154
164 // Creates an empty frame. 155 // Creates an empty frame.
165 virtual VideoFrame *CreateEmptyFrame(int w, int h, 156 virtual VideoFrame *CreateEmptyFrame(int w, int h,
166 int64_t time_stamp) const = 0; 157 int64_t time_stamp) const = 0;
167 virtual void SetRotation(webrtc::VideoRotation rotation) = 0; 158 virtual void SetRotation(webrtc::VideoRotation rotation) = 0;
168 }; 159 };
169 160
170 } // namespace cricket 161 } // namespace cricket
171 162
172 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_ 163 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/objc/public/RTCI420Frame.h ('k') | webrtc/media/base/videoframe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698