Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default.
This reverts back to the behaviour prior to https://codereview.webrtc.org/1773993002

BUG=chromium:594434
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/c0d31e915ca6d730c3d7a8219c229ad53a453201
Cr-Commit-Position: refs/heads/master@{#12181}

[perkj_webrtc, 2016-03-30 16:27:33]

Description was changed from

==========
Change needsdenoising() to optional.

BUG=
==========

to

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 

BUG=594434
==========

[perkj_webrtc, 2016-03-30 16:51:26]

Patchset #1 (id:1) has been deleted

[perkj_webrtc, 2016-03-30 16:51:35]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 16:51:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842073002/20001

[perkj_webrtc, 2016-03-30 16:52:49]

Description was changed from

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 

BUG=594434
==========

to

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=594434
==========

[perkj_webrtc, 2016-03-30 16:52:50]

perkj@webrtc.org changed reviewers:
+ pbos@webrtc.org, pthatcher@webrtc.org

[perkj_webrtc, 2016-03-30 16:54:12]

Please?

[pthatcher1, 2016-03-30 17:03:46]

lgtm

[commit-bot: I haz the power, 2016-03-30 18:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:52:13]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2016-03-31 14:28:00]

Description was changed from

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=594434
==========

to

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=chromium:594434
==========

[pbos-webrtc, 2016-03-31 14:30:08]

lgtm, please comment the heck out of this foot-shooter (and maybe a todo to
update it to a three-state enum, unless you wanna do that now)

https://codereview.webrtc.org/1842073002/diff/20001/webrtc/api/mediastreamint...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/1842073002/diff/20001/webrtc/api/mediastreamint...
webrtc/api/mediastreaminterface.h:131: virtual rtc::Optional<bool>
needs_denoising() const = 0;
Can we put a comment here on what unset means?

[perkj_webrtc, 2016-03-31 15:23:08]

https://codereview.webrtc.org/1842073002/diff/20001/webrtc/api/mediastreamint...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/1842073002/diff/20001/webrtc/api/mediastreamint...
webrtc/api/mediastreaminterface.h:131: virtual rtc::Optional<bool>
needs_denoising() const = 0;
On 2016/03/31 14:30:08, pbos-webrtc wrote:
> Can we put a comment here on what unset means?

Done.

[perkj_webrtc, 2016-03-31 15:23:56]

Description was changed from

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default. 
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=chromium:594434
==========

to

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default.
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=chromium:594434
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c0d31e915ca6d730c3d7a8219...
==========

[perkj_webrtc, 2016-03-31 15:23:58]

Committed patchset #3 (id:60001) manually as
c0d31e915ca6d730c3d7a8219c229ad53a453201 (presubmit successful).

[commit-bot: I haz the power, 2016-03-31 15:23:59]

Description was changed from

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default.
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=chromium:594434
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c0d31e915ca6d730c3d7a8219...
==========

to

==========
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

It turns out that it is used as if it has three states: on/off default.
This reverts back to the behaviour prior to
https://codereview.webrtc.org/1773993002

BUG=chromium:594434
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/c0d31e915ca6d730c3d7a8219c229ad53a453201
Cr-Commit-Position: refs/heads/master@{#12181}
==========

[commit-bot: I haz the power, 2016-03-31 15:24:00]

Patchset 3 (id:??) landed as
https://crrev.com/c0d31e915ca6d730c3d7a8219c229ad53a453201
Cr-Commit-Position: refs/heads/master@{#12181}