Add VideoTrackSource implementation.

Add implementation of VideoTrackSource and make  VideoCapturerTrackSource inherit from it.

BUG=webrtc:5426
R=pthatcher@webrtc.org

Committed: https://crrev.com/0d3eef20802f055ff0613e977430647c94c4928f
Cr-Commit-Position: refs/heads/master@{#11923}

[perkj_webrtc, 2016-03-08 00:56:46]

Description was changed from

==========
Split videocapturertracksource into VideoTrackSource

BUG=
==========

to

==========
Add implementation of VideoTrackSource and make  VideoCapturerTrackSource
inherit from it.

BUG=webrtc:5426
==========

[perkj_webrtc, 2016-03-08 00:56:47]

perkj@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[perkj_webrtc, 2016-03-08 00:59:15]

Please?

[perkj_webrtc, 2016-03-08 13:34:38]

Patchset #3 (id:40001) has been deleted

[perkj_webrtc, 2016-03-08 13:46:10]

Now also replaced VideoOptions with is_screencast and needs_denoising as
requested yesterday.

[pthatcher1, 2016-03-08 21:27:31]

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/mediastreamint...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/mediastreamint...
webrtc/api/mediastreaminterface.h:143: virtual bool needs_denoising() const = 0;
Can you put a comment in here like:

// Indicates that parameters suitable for screencasts should be automatically
applied to RtpSenders.  
// TODO: Remove these once all known applications have moved to explicitly
setting suitable parameters for screencasts and dont' need this implicit
behavior.

and

// Indicates that the encoder should denoise the video before encoding it.  
// TODO: Remove this once denoising is done by the source, and not by the
encoder.

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/rtpsender.cc
File webrtc/api/rtpsender.cc (right):

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/rtpsender.cc#n...
webrtc/api/rtpsender.cc:328: rtc::Optional<bool>(source->needs_denoising());
We should probably set these even when the track is not enabled (just check
if(source)).  That way, send parameters for screencasts that are disable and
re-enabled won't change dramatically in the process.

[perkj_webrtc, 2016-03-08 22:18:45]

Patchset #5 (id:100001) has been deleted

[perkj_webrtc, 2016-03-08 22:23:38]

Patchset #5 (id:120001) has been deleted

[perkj_webrtc, 2016-03-08 22:23:58]

ptal

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/mediastreamint...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/mediastreamint...
webrtc/api/mediastreaminterface.h:143: virtual bool needs_denoising() const = 0;
On 2016/03/08 21:27:31, pthatcher1 wrote:
> Can you put a comment in here like:
> 
> // Indicates that parameters suitable for screencasts should be automatically
> applied to RtpSenders.  
> // TODO: Remove these once all known applications have moved to explicitly
> setting suitable parameters for screencasts and dont' need this implicit
> behavior.
> 
> and
> 
> // Indicates that the encoder should denoise the video before encoding it.  
> // TODO: Remove this once denoising is done by the source, and not by the
> encoder.
> 

Done.

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/rtpsender.cc
File webrtc/api/rtpsender.cc (right):

https://codereview.webrtc.org/1773993002/diff/80001/webrtc/api/rtpsender.cc#n...
webrtc/api/rtpsender.cc:328: rtc::Optional<bool>(source->needs_denoising());
On 2016/03/08 21:27:31, pthatcher1 wrote:
> We should probably set these even when the track is not enabled (just check
> if(source)).  That way, send parameters for screencasts that are disable and
> re-enabled won't change dramatically in the process.

ah right...

[pthatcher1, 2016-03-08 22:42:33]

lgtm

[perkj_webrtc, 2016-03-08 22:53:41]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-08 22:53:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773993002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773993002/140001

[commit-bot: I haz the power, 2016-03-09 00:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 00:54:33]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[perkj_webrtc, 2016-03-09 01:39:38]

Description was changed from

==========
Add implementation of VideoTrackSource and make  VideoCapturerTrackSource
inherit from it.

BUG=webrtc:5426
==========

to

==========
Add implementation of VideoTrackSource and make  VideoCapturerTrackSource
inherit from it.

BUG=webrtc:5426
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/0d3eef20802f055ff0613e977...
==========

[commit-bot: I haz the power, 2016-03-09 01:39:38]

Description was changed from

==========
Add implementation of VideoTrackSource and make  VideoCapturerTrackSource
inherit from it.

BUG=webrtc:5426
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/0d3eef20802f055ff0613e977...
==========

to

==========
Add implementation of VideoTrackSource and make  VideoCapturerTrackSource
inherit from it.

BUG=webrtc:5426
R=pthatcher@webrtc.org

Committed: https://crrev.com/0d3eef20802f055ff0613e977430647c94c4928f
Cr-Commit-Position: refs/heads/master@{#11923}
==========

[perkj_webrtc, 2016-03-09 01:39:39]

Committed patchset #5 (id:140001) manually as
0d3eef20802f055ff0613e977430647c94c4928f (presubmit successful).

[commit-bot: I haz the power, 2016-03-09 01:39:39]

Patchset 5 (id:??) landed as
https://crrev.com/0d3eef20802f055ff0613e977430647c94c4928f
Cr-Commit-Position: refs/heads/master@{#11923}