autoroller: Use 10 characters for shortened Git hashes.

autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True

Committed: https://crrev.com/052af4cea213359d15aa2391ea4f63f493218577
Cr-Commit-Position: refs/heads/master@{#12156}

[kjellander_webrtc, 2016-03-30 07:25:54]

kjellander@webrtc.org changed reviewers:
+ pbos@webrtc.org

[kjellander_webrtc, 2016-03-30 07:26:03]

Description was changed from

==========
autoroller: Use 8 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding one more
char solves it:
https://chromium.googlesource.com/chromium/src/+/355fabff

BUG=
==========

to

==========
autoroller: Use 8 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding one more
char solves it:
https://chromium.googlesource.com/chromium/src/+/355fabff

NOTRY=True
==========

[pbos-webrtc, 2016-03-30 09:02:41]

lgtm, but I'd pref that we do 12 or something significantly larger, consider
that

https://codereview.webrtc.org/1841563004/diff/1/tools/autoroller/roll_chromiu...
File tools/autoroller/roll_chromium_revision.py (right):

https://codereview.webrtc.org/1841563004/diff/1/tools/autoroller/roll_chromiu...
tools/autoroller/roll_chromium_revision.py:256: current_cr_rev =
current_cr_rev[0:8]
tbh, pref if you just change this to 12

[kjellander_webrtc, 2016-03-30 09:27:54]

Description was changed from

==========
autoroller: Use 8 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding one more
char solves it:
https://chromium.googlesource.com/chromium/src/+/355fabff

NOTRY=True
==========

to

==========
autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True
==========

[kjellander_webrtc, 2016-03-30 09:28:46]

Good points. I decided on 10.

https://codereview.webrtc.org/1841563004/diff/1/tools/autoroller/roll_chromiu...
File tools/autoroller/roll_chromium_revision.py (right):

https://codereview.webrtc.org/1841563004/diff/1/tools/autoroller/roll_chromiu...
tools/autoroller/roll_chromium_revision.py:256: current_cr_rev =
current_cr_rev[0:8]
On 2016/03/30 09:02:40, pbos-webrtc wrote:
> tbh, pref if you just change this to 12

You're right that adding just one doesn't give us that much. I think 12 is a bit
too long so I'll go with 10 for now.

[kjellander_webrtc, 2016-03-30 09:28:50]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-03-30 09:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1841563004/#ps20001 (title:
"Bumping to 10 chars")

[commit-bot: I haz the power, 2016-03-30 09:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841563004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841563004/20001

[commit-bot: I haz the power, 2016-03-30 09:30:54]

Description was changed from

==========
autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True
==========

to

==========
autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-03-30 09:30:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-30 09:31:05]

Description was changed from

==========
autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True
==========

to

==========
autoroller: Use 10 characters for shortened Git hashes.

Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True

Committed: https://crrev.com/052af4cea213359d15aa2391ea4f63f493218577
Cr-Commit-Position: refs/heads/master@{#12156}
==========

[commit-bot: I haz the power, 2016-03-30 09:31:06]

Patchset 2 (id:??) landed as
https://crrev.com/052af4cea213359d15aa2391ea4f63f493218577
Cr-Commit-Position: refs/heads/master@{#12156}