autoroller: Use 10 characters for shortened Git hashes.

tools/autoroller/roll_chromium_revision.py

 #!/usr/bin/env python
 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 """Script to roll chromium_revision in the WebRTC DEPS file."""
@@ skipping 235 matching lines @@
   current_rev = GetClangRev(current_lines)
 
   new_clang_update_py = ReadRemoteCrFile(CLANG_UPDATE_SCRIPT_URL_PATH,
                                              new_cr_rev).splitlines()
   new_rev = GetClangRev(new_clang_update_py)
   return ChangedDep(CLANG_UPDATE_SCRIPT_LOCAL_PATH, None, current_rev, new_rev)
 
 
 def GenerateCommitMessage(current_cr_rev, new_cr_rev, current_commit_pos,
                           new_commit_pos, changed_deps_list, clang_change):
-  current_cr_rev = current_cr_rev[0:7]
-  new_cr_rev = new_cr_rev[0:7]
+  current_cr_rev = current_cr_rev[0:8]

[pbos-webrtc, 2016/03/30 09:02:40]

tbh, pref if you just change this to 12

[kjellander_webrtc, 2016/03/30 09:28:46]

You're right that adding just one doesn't give us that much. I think 12 is a bit
too long so I'll go with 10 for now.

+  new_cr_rev = new_cr_rev[0:8]
   rev_interval = '%s..%s' % (current_cr_rev, new_cr_rev)
   git_number_interval = '%s:%s' % (current_commit_pos, new_commit_pos)
 
   commit_msg = ['Roll chromium_revision %s (%s)\n' % (rev_interval,
                                                     git_number_interval)]
   commit_msg.append('Change log: %s' % (CHROMIUM_LOG_TEMPLATE % rev_interval))
   commit_msg.append('Full diff: %s\n' % (CHROMIUM_COMMIT_TEMPLATE %
                                          rev_interval))
   # TBR field will be empty unless in some custom cases, where some engineers
   # are added.
   tbr_authors = ''
   if changed_deps_list:
     commit_msg.append('Changed dependencies:')
 
     for c in changed_deps_list:
       commit_msg.append('* %s: %s/+log/%s..%s' % (c.path, c.url,
-                                                  c.current_rev[0:7],
-                                                  c.new_rev[0:7]))
+                                                  c.current_rev[0:8],
+                                                  c.new_rev[0:8]))
       if 'libvpx' in c.path:
         tbr_authors += 'marpan@webrtc.org, stefan@webrtc.org, '
 
     change_url = CHROMIUM_FILE_TEMPLATE % (rev_interval, 'DEPS')
     commit_msg.append('DEPS diff: %s\n' % change_url)
   else:
     commit_msg.append('No dependencies changed.')
 
   if clang_change.current_rev != clang_change.new_rev:
     commit_msg.append('Clang version changed %s:%s' %
@@ skipping 151 matching lines @@
   _CreateRollBranch(opts.dry_run)
   UpdateDeps(deps_filename, current_cr_rev, new_cr_rev)
   _LocalCommit(commit_msg, opts.dry_run)
   _UploadCL(opts.dry_run, opts.rietveld_email)
   _SendToCQ(opts.dry_run, opts.skip_cq)
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())