Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841323002: Fix division by zero in NonlinearBeamformer (Closed)

Created:
4 years, 8 months ago by aluebs-webrtc
Modified:
4 years, 8 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix division by zero in NonlinearBeamformer BUG=webrtc:5703 Committed: https://crrev.com/fc737e5442792d72de22d1271471b9d7a0e45c0b Cr-Commit-Position: refs/heads/master@{#12163}

Patch Set 1 #

Patch Set 2 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc View 1 11 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aluebs-webrtc
Let's wait to see what the bots say, but this should fix the division by ...
4 years, 8 months ago (2016-03-30 00:58:00 UTC) #2
peah-webrtc
On 2016/03/30 00:58:00, aluebs-webrtc wrote: > Let's wait to see what the bots say, but ...
4 years, 8 months ago (2016-03-30 04:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841323002/20001
4 years, 8 months ago (2016-03-30 16:36:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 16:37:47 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:37:52 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fc737e5442792d72de22d1271471b9d7a0e45c0b
Cr-Commit-Position: refs/heads/master@{#12163}

Powered by Google App Engine
This is Rietveld 408576698