Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc

Issue 1841323002: Fix division by zero in NonlinearBeamformer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove TODO Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc
diff --git a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc
index 6ea7234f6f61d5b860ff6a0ac5baac9dbb361daa..118b38d487b52d0cfd34be39dbe000ab67dd93d2 100644
--- a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc
+++ b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc
@@ -471,8 +471,17 @@ float NonlinearBeamformer::CalculatePostfilterMask(
ratio = rpsiw / rpsim;
}
- return (1.f - std::min(kCutOffConstant, ratio / rmw_r)) /
- (1.f - std::min(kCutOffConstant, ratio / ratio_rxiw_rxim));
+ float numerator = 1.f - kCutOffConstant;
+ if (rmw_r > 0.f) {
+ numerator = 1.f - std::min(kCutOffConstant, ratio / rmw_r);
+ }
+
+ float denominator = 1.f - kCutOffConstant;
+ if (ratio_rxiw_rxim > 0.f) {
+ denominator = 1.f - std::min(kCutOffConstant, ratio / ratio_rxiw_rxim);
+ }
+
+ return numerator / denominator;
}
void NonlinearBeamformer::ApplyMasks(const complex_f* const* input,
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698