Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.

Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.

BUG=

Committed: https://crrev.com/7ea928e8e2eb47bc3278498fc5775e7cfb1c3ead
Cr-Commit-Position: refs/heads/master@{#12162}

[peah-webrtc, 2016-03-29 20:58:59]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-03-29 21:02:00]

peah@webrtc.org changed reviewers:
+ aluebs@webrtc.org, henrik.lundin@webrtc.org

[peah-webrtc, 2016-03-29 21:02:01]

Hi,
As discussed in a previous CL, the method name BitExactFrame is misleading and
incorrect. This CL addresses that by proposing a name change.

[hlundin-webrtc, 2016-03-29 21:31:59]

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/bitexactness_tools.h (right):

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/bitexactness_tools.h:40:
::testing::AssertionResult VectorDifferenceBounded(
The two methods now share the same name. However, the comments talk about
"frame" and "vector". Consider merging into one function comment, and highlight
the difference between the two methods.

[aluebs-webrtc, 2016-03-29 22:04:43]

lgtm % small suggestion

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
(left):

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc:114:
const float kTolerance = 1.f / static_cast<float>(1 << 15);
I think it is not necessary to rename the tolerance, but if you find the new
name more descriptive, I don't mind.

[peah-webrtc, 2016-03-30 04:14:45]

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
(left):

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc:114:
const float kTolerance = 1.f / static_cast<float>(1 << 15);
On 2016/03/29 22:04:43, aluebs-webrtc wrote:
> I think it is not necessary to rename the tolerance, but if you find the new
> name more descriptive, I don't mind.

Acknowledged.

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/bitexactness_tools.h (right):

https://codereview.webrtc.org/1841213002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/bitexactness_tools.h:40:
::testing::AssertionResult VectorDifferenceBounded(
On 2016/03/29 21:31:59, hlundin-webrtc wrote:
> The two methods now share the same name. However, the comments talk about
> "frame" and "vector". Consider merging into one function comment, and
highlight
> the difference between the two methods.

Good point! I changed the name of one of them to be more descriptive to what is
being done in the method. Could you please take another look!

[hlundin-webrtc, 2016-03-30 08:21:11]

https://codereview.webrtc.org/1841213002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/bitexactness_tools.h (right):

https://codereview.webrtc.org/1841213002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/bitexactness_tools.h:40:
::testing::AssertionResult StackedFrameDifferenceBounded(
Suggest VerifyDeinterleavedArray. And for symmetry reasons, call the other one
Verify(Interleaved)Array.

[peah-webrtc, 2016-03-30 12:16:36]

Hi,
I changed to the suggested method names. Please not that the new patch includes
a rebase containing with some TODOs.

https://codereview.webrtc.org/1841213002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/bitexactness_tools.h (right):

https://codereview.webrtc.org/1841213002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/bitexactness_tools.h:40:
::testing::AssertionResult StackedFrameDifferenceBounded(
On 2016/03/30 08:21:11, hlundin-webrtc wrote:
> Suggest VerifyDeinterleavedArray. And for symmetry reasons, call the other one
> Verify(Interleaved)Array.

Great suggestion!
Done.

[hlundin-webrtc, 2016-03-30 12:31:22]

lgtm

[peah-webrtc, 2016-03-30 12:31:44]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-03-30 12:31:44]

The patchset sent to the CQ was uploaded after l-g-t-m from aluebs@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1841213002/#ps60001 (title:
"Changed name of the StackedFrameDifferenceBounded and VectorDifferenceBounded
methods")

[commit-bot: I haz the power, 2016-03-30 12:31:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841213002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841213002/60001

[commit-bot: I haz the power, 2016-03-30 14:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 14:32:32]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-03-30 14:33:32]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-03-30 14:33:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841213002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841213002/60001

[commit-bot: I haz the power, 2016-03-30 15:14:00]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-30 15:14:08]

Description was changed from

==========
Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.

BUG=
==========

to

==========
Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.

BUG=

Committed: https://crrev.com/7ea928e8e2eb47bc3278498fc5775e7cfb1c3ead
Cr-Commit-Position: refs/heads/master@{#12162}
==========

[commit-bot: I haz the power, 2016-03-30 15:14:09]

Patchset 3 (id:??) landed as
https://crrev.com/7ea928e8e2eb47bc3278498fc5775e7cfb1c3ead
Cr-Commit-Position: refs/heads/master@{#12162}