webrtc/modules/audio_processing/echo_cancellation_unittest.cc - Issue 1841213002: Renamed the test::BitExactFrame method to test::VectorDifferenceBounded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_unittest.cc

Issue 1841213002: Renamed the test::BitExactFrame method to test::VectorDifferenceBounded. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changed name of the StackedFrameDifferenceBounded and VectorDifferenceBounded methods Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc ('k') | webrtc/modules/audio_processing/echo_control_mobile_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/echo_cancellation_unittest.cc

diff --git a/webrtc/modules/audio_processing/echo_cancellation_unittest.cc b/webrtc/modules/audio_processing/echo_cancellation_unittest.cc

index ccf80f3ff564bbfccbf151bd9d38a9ff80225bb0..97849d7590a050114c57c0f97890da16d01b7777 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_unittest.cc

+++ b/webrtc/modules/audio_processing/echo_cancellation_unittest.cc

@@ -125,10 +125,10 @@ void RunBitexactnessTest(int sample_rate_hz,

// preceeding frames as testvectors. As the algorithm being tested has a

// memory, testing only the last frame implicitly also tests the preceeding

// frames.

- const float kTolerance = 1.0f / 32768.0f;

- EXPECT_TRUE(test::BitExactFrame(

+ const float kElementErrorBound = 1.0f / 32768.0f;

+ EXPECT_TRUE(test::VerifyDeinterleavedArray(

capture_config.num_frames(), capture_config.num_channels(),

- output_reference, capture_output, kTolerance));

+ output_reference, capture_output, kElementErrorBound));

}

const bool kStreamHasEchoReference = false;