Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: webrtc/api/mediastreamprovider.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/rtpsender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/mediastreamprovider.h
diff --git a/webrtc/api/mediastreamprovider.h b/webrtc/api/mediastreamprovider.h
index b23e17bd4bb959a1bfd57a4f5f02c649945de471..b508c39f7e0289e3fb3c79eac3491275c0022662 100644
--- a/webrtc/api/mediastreamprovider.h
+++ b/webrtc/api/mediastreamprovider.h
@@ -80,18 +80,21 @@ class AudioProviderInterface {
// of a video track connected to a certain PeerConnection.
class VideoProviderInterface {
public:
- virtual bool SetSource(
- uint32_t ssrc,
- rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
// Enable/disable the video playout of a remote video track with |ssrc|.
virtual void SetVideoPlayout(
uint32_t ssrc,
bool enable,
rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
- // Enable sending video on the local video track with |ssrc|.
- virtual void SetVideoSend(uint32_t ssrc,
- bool enable,
- const cricket::VideoOptions* options) = 0;
+ // Enable/disable sending video on the local video track with |ssrc|.
+ // TODO(deadbeef): Make |options| a reference parameter.
+ // TODO(deadbeef): Eventually, |enable| and |options| will be contained
+ // in |source|. When that happens, remove those parameters and rename
+ // this to SetVideoSource.
+ virtual void SetVideoSend(
+ uint32_t ssrc,
+ bool enable,
+ const cricket::VideoOptions* options,
+ rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
virtual RtpParameters GetVideoRtpSendParameters(uint32_t ssrc) const = 0;
virtual bool SetVideoRtpSendParameters(uint32_t ssrc,
« no previous file with comments | « no previous file | webrtc/api/rtpsender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698