Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: webrtc/api/mediastreamprovider.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/rtpsender.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 const RtpParameters& parameters) = 0; 73 const RtpParameters& parameters) = 0;
74 74
75 protected: 75 protected:
76 virtual ~AudioProviderInterface() {} 76 virtual ~AudioProviderInterface() {}
77 }; 77 };
78 78
79 // This interface is called by VideoRtpSender/Receivers to change the settings 79 // This interface is called by VideoRtpSender/Receivers to change the settings
80 // of a video track connected to a certain PeerConnection. 80 // of a video track connected to a certain PeerConnection.
81 class VideoProviderInterface { 81 class VideoProviderInterface {
82 public: 82 public:
83 virtual bool SetSource(
84 uint32_t ssrc,
85 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
86 // Enable/disable the video playout of a remote video track with |ssrc|. 83 // Enable/disable the video playout of a remote video track with |ssrc|.
87 virtual void SetVideoPlayout( 84 virtual void SetVideoPlayout(
88 uint32_t ssrc, 85 uint32_t ssrc,
89 bool enable, 86 bool enable,
90 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0; 87 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
91 // Enable sending video on the local video track with |ssrc|. 88 // Enable/disable sending video on the local video track with |ssrc|.
92 virtual void SetVideoSend(uint32_t ssrc, 89 // TODO(deadbeef): Make |options| a reference parameter.
93 bool enable, 90 // TODO(deadbeef): Eventually, |enable| and |options| will be contained
94 const cricket::VideoOptions* options) = 0; 91 // in |source|. When that happens, remove those parameters and rename
92 // this to SetVideoSource.
93 virtual void SetVideoSend(
94 uint32_t ssrc,
95 bool enable,
96 const cricket::VideoOptions* options,
97 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
95 98
96 virtual RtpParameters GetVideoRtpSendParameters(uint32_t ssrc) const = 0; 99 virtual RtpParameters GetVideoRtpSendParameters(uint32_t ssrc) const = 0;
97 virtual bool SetVideoRtpSendParameters(uint32_t ssrc, 100 virtual bool SetVideoRtpSendParameters(uint32_t ssrc,
98 const RtpParameters& parameters) = 0; 101 const RtpParameters& parameters) = 0;
99 102
100 virtual RtpParameters GetVideoRtpReceiveParameters(uint32_t ssrc) const = 0; 103 virtual RtpParameters GetVideoRtpReceiveParameters(uint32_t ssrc) const = 0;
101 virtual bool SetVideoRtpReceiveParameters( 104 virtual bool SetVideoRtpReceiveParameters(
102 uint32_t ssrc, 105 uint32_t ssrc,
103 const RtpParameters& parameters) = 0; 106 const RtpParameters& parameters) = 0;
104 107
105 protected: 108 protected:
106 virtual ~VideoProviderInterface() {} 109 virtual ~VideoProviderInterface() {}
107 }; 110 };
108 111
109 } // namespace webrtc 112 } // namespace webrtc
110 113
111 #endif // WEBRTC_API_MEDIASTREAMPROVIDER_H_ 114 #endif // WEBRTC_API_MEDIASTREAMPROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/rtpsender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698