cricket::VideoFrame cleanup. New width() and height(). Deleted GetChroma* methods.

Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
Committed: https://crrev.com/71a0c2f9a6876fd164f136d58389028c1ba70c18
Cr-Commit-Position: refs/heads/master@{#12213}

[nisse-webrtc, 2016-03-30 11:17:12]

Description was changed from

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
==========

to

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
==========

[nisse-webrtc, 2016-03-30 11:17:18]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 11:17:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838353004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838353004/1

[commit-bot: I haz the power, 2016-03-30 11:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 11:45:43]

Dry run: Try jobs failed on following builders:
  win_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/13859)

[nisse-webrtc, 2016-03-30 12:09:55]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 12:10:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838353004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838353004/20001

[nisse-webrtc, 2016-03-30 12:26:47]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org, tkchin@webrtc.org

[nisse-webrtc, 2016-03-30 12:26:48]

Hi, this cl moves the cricket::VideoFrame interface one step closer to
webrtc::VideoFrame, which will ultimately replace it.

[commit-bot: I haz the power, 2016-03-30 14:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 14:38:12]

Dry run: This issue passed the CQ dry run.

[tkchin_webrtc, 2016-03-30 17:35:06]

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:47: return ([self width] + 1) / 2;
dot syntax for properties
self.width
self.height
self.chromaWidth + self.chromeHeight

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:47: return ([self width] + 1) / 2;
Is this always going to be true? This assumes that every frame will be I420,
which might not be the case if there is a native handle.

https://codereview.webrtc.org/1838353004/diff/20001/webrtc/api/objc/RTCVideoF...
File webrtc/api/objc/RTCVideoFrame.mm (right):

https://codereview.webrtc.org/1838353004/diff/20001/webrtc/api/objc/RTCVideoF...
webrtc/api/objc/RTCVideoFrame.mm:30: return ([self width] + 1) / 2;
ditto

[perkj_webrtc, 2016-03-31 04:58:23]

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:47: return ([self width] + 1) / 2;
On 2016/03/30 17:35:06, tkchin_webrtc wrote:
> dot syntax for properties
> self.width
> self.height
> self.chromaWidth + self.chromeHeight

Are these actually used for anything? Cant we just remove them here too? If not-
this is actually how these values are calculated today in  videoframe.h.

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:54: - (NSUInteger)chromaSize {
dito? Unused?

[nisse-webrtc, 2016-03-31 08:21:58]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 08:22:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838353004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838353004/40001

[nisse-webrtc, 2016-03-31 08:22:18]

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:47: return ([self width] + 1) / 2;
On 2016/03/30 17:35:06, tkchin_webrtc wrote:
> dot syntax for properties
> self.width
> self.height
> self.chromaWidth + self.chromeHeight

Done.

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:47: return ([self width] + 1) / 2;
On 2016/03/30 17:35:06, tkchin_webrtc wrote:
> Is this always going to be true? This assumes that every frame will be I420,
> which might not be the case if there is a native handle.

This is no change in behavior. Probably with the motivation that "chroma" makes
sense only for yuv frames.

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:54: - (NSUInteger)chromaSize {
On 2016/03/31 04:58:23, perkj_webrtc wrote:
> dito? Unused?

The chromaSize property appear to be completely unused. So I'm deleting it.

chromaWidth and chromaHeight are used only in RTCOpenGlVideoRenderer.mm. Can
perhaps be removed there, but I think I'd prefer to not do that in this cl.

[commit-bot: I haz the power, 2016-03-31 10:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 10:22:27]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2016-03-31 14:49:09]

lgtm

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1838353004/diff/20001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:54: - (NSUInteger)chromaSize {
On 2016/03/31 08:22:17, nisse-webrtc wrote:
> On 2016/03/31 04:58:23, perkj_webrtc wrote:
> > dito? Unused?
> 
> The chromaSize property appear to be completely unused. So I'm deleting it.
> 
> chromaWidth and chromaHeight are used only in RTCOpenGlVideoRenderer.mm. Can
> perhaps be removed there, but I think I'd prefer to not do that in this cl.

Can you put a TODO here to do that?

https://codereview.webrtc.org/1838353004/diff/20001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe.h (right):

https://codereview.webrtc.org/1838353004/diff/20001/webrtc/media/base/videofr...
webrtc/media/base/videoframe.h:51: // Deprecated methods, for backwards
compatibility.
Put a TODO with you as owner to remove them. And that they will be removed as
soon as X happens. (replace X)

https://codereview.webrtc.org/1838353004/diff/40001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe.h (right):

https://codereview.webrtc.org/1838353004/diff/40001/webrtc/media/base/videofr...
webrtc/media/base/videoframe.h:51: // Deprecated methods, for backwards
compatibility.
Put a TODO to remove them pref. (and when they're going to be removed, e.g. we
have to remove usage from X)

https://codereview.webrtc.org/1838353004/diff/40001/webrtc/media/devices/gdiv...
File webrtc/media/devices/gdivideorenderer.cc (right):

https://codereview.webrtc.org/1838353004/diff/40001/webrtc/media/devices/gdiv...
webrtc/media/devices/gdivideorenderer.cc:247: frame.width(), frame.height()));
git cl format I think?

[tkchin_webrtc, 2016-03-31 15:43:16]

lgtm

[perkj_webrtc, 2016-04-01 12:20:24]

lgtm

[nisse-webrtc, 2016-04-01 12:20:50]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-04-01 12:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1838353004/#ps60001 (title:
"TODO comments. Formatting tweak.")

[commit-bot: I haz the power, 2016-04-01 12:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838353004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838353004/60001

[commit-bot: I haz the power, 2016-04-01 14:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 14:21:39]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[nisse-webrtc, 2016-04-04 06:21:15]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-04-04 06:21:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838353004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838353004/60001

[commit-bot: I haz the power, 2016-04-04 07:57:32]

Description was changed from

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
==========

to

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
==========

[commit-bot: I haz the power, 2016-04-04 07:57:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-04 07:57:41]

Description was changed from

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682
==========

to

==========
Deprecate GetWidth() and GetHeight() methods. Replaced by width() and height().

Delete GetChromaWidth, GetChromaHeight, and GetChromaSize.

Delete unused function VideoFrameEqual.

BUG=webrtc:5682

Committed: https://crrev.com/71a0c2f9a6876fd164f136d58389028c1ba70c18
Cr-Commit-Position: refs/heads/master@{#12213}
==========

[commit-bot: I haz the power, 2016-04-04 07:57:43]

Patchset 4 (id:??) landed as
https://crrev.com/71a0c2f9a6876fd164f136d58389028c1ba70c18
Cr-Commit-Position: refs/heads/master@{#12213}