Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: webrtc/api/objc/RTCVideoFrame.mm

Issue 1838353004: cricket::VideoFrame cleanup. New width() and height(). Deleted GetChroma* methods. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: TODO comments. Formatting tweak. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCVideoFrame.h ('k') | webrtc/api/objc/RTCVideoRendererAdapter.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCVideoFrame.mm
diff --git a/webrtc/api/objc/RTCVideoFrame.mm b/webrtc/api/objc/RTCVideoFrame.mm
index db2d07ba31a82a1e8371529cc5ff22592a42034e..d70ab372ac86ea8fd2a7efb48fb862d6ffee7b0d 100644
--- a/webrtc/api/objc/RTCVideoFrame.mm
+++ b/webrtc/api/objc/RTCVideoFrame.mm
@@ -19,23 +19,22 @@
}
- (size_t)width {
- return _videoFrame->GetWidth();
+ return _videoFrame->width();
}
- (size_t)height {
- return _videoFrame->GetHeight();
+ return _videoFrame->height();
}
+// TODO(nisse): chromaWidth and chromaHeight are used only in
+// RTCOpenGLVideoRenderer.mm. Update, and then delete these
+// properties.
- (size_t)chromaWidth {
- return _videoFrame->GetChromaWidth();
+ return (self.width + 1) / 2;
}
- (size_t)chromaHeight {
- return _videoFrame->GetChromaHeight();
-}
-
-- (size_t)chromaSize {
- return _videoFrame->GetChromaSize();
+ return (self.height + 1) / 2;
}
- (const uint8_t *)yPlane {
« no previous file with comments | « webrtc/api/objc/RTCVideoFrame.h ('k') | webrtc/api/objc/RTCVideoRendererAdapter.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698