Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1836663002: Ignore iOS SDK during presubmit. (Closed)

Created:
4 years, 9 months ago by hjon_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore iOS SDK during presubmit. NOTRY=True Committed: https://crrev.com/65ae2d81cac95b9b3b16f6ad7281bb2c72e82bd4 Cr-Commit-Position: refs/heads/master@{#13618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
hjon_webrtc
Ignoring Obj-C files added with https://codereview.webrtc.org/1829783003/
4 years, 9 months ago (2016-03-25 22:07:24 UTC) #2
kjellander_webrtc
lgtm. I suggest referencing https://codereview.webrtc.org/1829783003/ in the CL description and also a BUG= reference for ...
4 years, 8 months ago (2016-03-29 08:41:22 UTC) #3
tkchin_webrtc
On 2016/03/29 08:41:22, kjellander (webrtc) wrote: > lgtm. I suggest referencing https://codereview.webrtc.org/1829783003/ in the CL ...
4 years, 8 months ago (2016-03-29 21:35:35 UTC) #4
kjellander_webrtc
On 2016/03/29 21:35:35, tkchin_webrtc wrote: > On 2016/03/29 08:41:22, kjellander (webrtc) wrote: > > lgtm. ...
4 years, 4 months ago (2016-08-02 19:49:32 UTC) #5
tkchin_webrtc
No longer working with us, but I think this should still go in.
4 years, 4 months ago (2016-08-02 22:28:58 UTC) #6
kjellander_webrtc
On 2016/08/02 22:28:58, tkchin_webrtc wrote: > No longer working with us, but I think this ...
4 years, 4 months ago (2016-08-03 06:53:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/1836663002/1
4 years, 4 months ago (2016-08-03 06:53:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 06:55:50 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 06:55:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65ae2d81cac95b9b3b16f6ad7281bb2c72e82bd4
Cr-Commit-Position: refs/heads/master@{#13618}

Powered by Google App Engine
This is Rietveld 408576698