Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: PRESUBMIT.py

Issue 1836663002: Ignore iOS SDK during presubmit. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 return input_api.RunTests(tests, parallel=True) 396 return input_api.RunTests(tests, parallel=True)
397 397
398 398
399 def _CommonChecks(input_api, output_api): 399 def _CommonChecks(input_api, output_api):
400 """Checks common to both upload and commit.""" 400 """Checks common to both upload and commit."""
401 results = [] 401 results = []
402 # Filter out files that are in objc or ios dirs from being cpplint-ed since 402 # Filter out files that are in objc or ios dirs from being cpplint-ed since
403 # they do not follow C++ lint rules. 403 # they do not follow C++ lint rules.
404 black_list = input_api.DEFAULT_BLACK_LIST + ( 404 black_list = input_api.DEFAULT_BLACK_LIST + (
405 r".*\bobjc[\\\/].*", 405 r".*\bobjc[\\\/].*",
406 r"webrtc\/build\/ios\/SDK\/.*",
406 ) 407 )
407 source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list) 408 source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)
408 results.extend(_CheckApprovedFilesLintClean( 409 results.extend(_CheckApprovedFilesLintClean(
409 input_api, output_api, source_file_filter)) 410 input_api, output_api, source_file_filter))
410 results.extend(input_api.canned_checks.RunPylint(input_api, output_api, 411 results.extend(input_api.canned_checks.RunPylint(input_api, output_api,
411 black_list=(r'^.*gviz_api\.py$', 412 black_list=(r'^.*gviz_api\.py$',
412 r'^.*gaeunit\.py$', 413 r'^.*gaeunit\.py$',
413 # Embedded shell-script fakes out pylint. 414 # Embedded shell-script fakes out pylint.
414 r'^build[\\\/].*\.py$', 415 r'^build[\\\/].*\.py$',
415 r'^buildtools[\\\/].*\.py$', 416 r'^buildtools[\\\/].*\.py$',
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 for builder in masters[master]: 511 for builder in masters[master]:
511 if 'presubmit' in builder: 512 if 'presubmit' in builder:
512 # Do not trigger presubmit builders, since they're likely to fail 513 # Do not trigger presubmit builders, since they're likely to fail
513 # (e.g. OWNERS checks before finished code review), and we're running 514 # (e.g. OWNERS checks before finished code review), and we're running
514 # local presubmit anyway. 515 # local presubmit anyway.
515 pass 516 pass
516 else: 517 else:
517 try_config[master][builder] = ['defaulttests'] 518 try_config[master][builder] = ['defaulttests']
518 519
519 return try_config 520 return try_config
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698