Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1835833004: Added missing TODOs in the beamformer unit test code. (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added missing TODOs in the beamformer unit test code. BUG= Committed: https://crrev.com/059dadf0c4686e9793cf18063bf30d50d787258c Cr-Commit-Position: refs/heads/master@{#12151}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved one of the TODOs to a more appropriate place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
peah-webrtc
4 years, 8 months ago (2016-03-29 17:10:43 UTC) #2
aluebs-webrtc
lgtm % 1 small comment https://codereview.webrtc.org/1835833004/diff/1/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc (right): https://codereview.webrtc.org/1835833004/diff/1/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc#newcode250 webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc:250: // TODO(peah): Add bitexactness ...
4 years, 8 months ago (2016-03-29 18:59:49 UTC) #3
peah-webrtc
https://codereview.webrtc.org/1835833004/diff/1/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc (right): https://codereview.webrtc.org/1835833004/diff/1/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc#newcode250 webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc:250: // TODO(peah): Add bitexactness tests for scenarios with more ...
4 years, 8 months ago (2016-03-29 21:05:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835833004/20001
4 years, 8 months ago (2016-03-29 21:05:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 22:15:13 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 22:15:18 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/059dadf0c4686e9793cf18063bf30d50d787258c
Cr-Commit-Position: refs/heads/master@{#12151}

Powered by Google App Engine
This is Rietveld 408576698